Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 10388208: Add test case for custom error's toString. (Closed)

Created:
8 years, 7 months ago by Yang
Modified:
8 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add test case for custom error's toString. R=arv@chromium.org BUG= TEST=error-tostring.js Committed: https://code.google.com/p/v8/source/detail?r=12151

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M test/cctest/test-api.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yang
PTAL.
8 years, 7 months ago (2012-05-21 07:57:23 UTC) #1
arv (Not doing code reviews)
http://codereview.chromium.org/10388208/diff/1/test/mjsunit/error-tostring.js File test/mjsunit/error-tostring.js (right): http://codereview.chromium.org/10388208/diff/1/test/mjsunit/error-tostring.js#newcode103 test/mjsunit/error-tostring.js:103: assertEquals('MyError toString', e.toString()); I don't think this tests the ...
8 years, 7 months ago (2012-05-21 16:40:03 UTC) #2
Yang
Sorry that this took that long. I have had my plate full. I changed the ...
8 years, 6 months ago (2012-06-19 14:00:18 UTC) #3
Yang
On 2012/06/19 14:00:18, Yang wrote: > Sorry that this took that long. I have had ...
8 years, 5 months ago (2012-06-29 13:07:33 UTC) #4
Yang
On 2012/06/29 13:07:33, Yang wrote: > On 2012/06/19 14:00:18, Yang wrote: > > Sorry that ...
8 years, 5 months ago (2012-07-19 08:07:46 UTC) #5
arv (Not doing code reviews)
8 years, 5 months ago (2012-07-19 20:50:11 UTC) #6
LGTM

Sorry. This did not show up in my priority inbox.

Powered by Google App Engine
This is Rietveld 408576698