Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 10388203: [Views, WebIntents] Enable auto-resizing for WebContents (Closed)

Created:
8 years, 7 months ago by groby-ooo-7-16
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Views, WebIntents] Enable auto-resizing for WebContents R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138297

Patch Set 1 #

Patch Set 2 : [Views, WebIntents] Auto-resize inline disposition. #

Patch Set 3 : Actually made resize work #

Total comments: 2

Patch Set 4 : Fix review nit. #

Patch Set 5 : Re-base to HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 2 3 4 5 chunks +11 lines, -4 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
groby-ooo-7-16
I'd appreciate your help on this, if you have a second. If I don't run ...
8 years, 7 months ago (2012-05-18 22:16:57 UTC) #1
groby-ooo-7-16
Found it - thanks for walking me through things. Now I just need a review ...
8 years, 7 months ago (2012-05-19 00:37:35 UTC) #2
sky
LGTM https://chromiumcodereview.appspot.com/10388203/diff/4001/ui/views/controls/webview/webview.h File ui/views/controls/webview/webview.h (right): https://chromiumcodereview.appspot.com/10388203/diff/4001/ui/views/controls/webview/webview.h#newcode75 ui/views/controls/webview/webview.h:75: void SetPreferredSize(const gfx::Size& preferred_size); How about: "Sets the ...
8 years, 7 months ago (2012-05-21 14:47:05 UTC) #3
groby-ooo-7-16
https://chromiumcodereview.appspot.com/10388203/diff/4001/ui/views/controls/webview/webview.h File ui/views/controls/webview/webview.h (right): https://chromiumcodereview.appspot.com/10388203/diff/4001/ui/views/controls/webview/webview.h#newcode75 ui/views/controls/webview/webview.h:75: void SetPreferredSize(const gfx::Size& preferred_size); On 2012/05/21 14:47:05, sky wrote: ...
8 years, 7 months ago (2012-05-21 18:58:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10388203/3004
8 years, 7 months ago (2012-05-22 00:18:40 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 07:21:46 UTC) #6
Try job failure for 10388203-3004 (previous was lost) (retry) (retry) on win_rel
for steps "base_unittests, sync_unit_tests" (clobber build).
It's a second try, previously, steps "base_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698