Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10388202: Base: Don't overwrite the thread id when ThreadMain exits. There's (Closed)

Created:
8 years, 7 months ago by rvargas (doing something else)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Base: Don't overwrite the thread id when ThreadMain exits. There's no need to do that, and it makes debugging easier to have the value. BUG=127931 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/threading/thread.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rvargas (doing something else)
8 years, 7 months ago (2012-05-18 21:43:51 UTC) #1
willchan no longer on Chromium
Lgtm On May 18, 2012 2:43 PM, <rvargas@chromium.org> wrote: > Reviewers: willchan, > > Description: ...
8 years, 7 months ago (2012-05-18 21:49:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/10388202/1
8 years, 7 months ago (2012-05-18 22:58:43 UTC) #3
commit-bot: I haz the power
Try job failure for 10388202-1 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=12290 Step "update" is always ...
8 years, 7 months ago (2012-05-18 23:24:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/10388202/1
8 years, 7 months ago (2012-05-19 01:39:21 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-19 02:36:52 UTC) #6
Try job failure for 10388202-1 (retry) on mac_rel for steps "base_unittests,
browser_tests, unit_tests, content_unittests, media_unittests".
It's a second try, previously, steps "base_unittests, browser_tests, unit_tests,
content_unittests, media_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698