Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10388198: ash: Add the SYNTHETIC flag to mouse-events generated from gestures. (Closed)

Created:
8 years, 7 months ago by sadrul
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Add the SYNTHETIC flag to mouse-events generated from gestures. This fixes the cases where the cursor shows up when touching on views that don't process gesture events. BUG=117986 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137942

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : updates-test #

Total comments: 3

Patch Set 4 : EF_FROM_TOUCH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -2 lines) Patch
M ui/aura/aura.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
A ui/aura/shared/root_window_event_filter_unittest.cc View 1 2 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
8 years, 7 months ago (2012-05-18 19:03:33 UTC) #1
sky
http://codereview.chromium.org/10388198/diff/5001/ui/aura/root_window.cc File ui/aura/root_window.cc (right): http://codereview.chromium.org/10388198/diff/5001/ui/aura/root_window.cc#newcode748 ui/aura/root_window.cc:748: event->flags() | ui::EF_IS_SYNTHESIZED); We want ET_FROM_TOUCH here.
8 years, 7 months ago (2012-05-18 19:53:29 UTC) #2
sadrul
http://codereview.chromium.org/10388198/diff/5001/ui/aura/root_window.cc File ui/aura/root_window.cc (right): http://codereview.chromium.org/10388198/diff/5001/ui/aura/root_window.cc#newcode748 ui/aura/root_window.cc:748: event->flags() | ui::EF_IS_SYNTHESIZED); On 2012/05/18 19:53:29, sky wrote: > ...
8 years, 7 months ago (2012-05-18 19:58:45 UTC) #3
sadrul
http://codereview.chromium.org/10388198/diff/5001/ui/aura/root_window.cc File ui/aura/root_window.cc (right): http://codereview.chromium.org/10388198/diff/5001/ui/aura/root_window.cc#newcode748 ui/aura/root_window.cc:748: event->flags() | ui::EF_IS_SYNTHESIZED); On 2012/05/18 19:53:29, sky wrote: > ...
8 years, 7 months ago (2012-05-18 20:02:03 UTC) #4
sky
8 years, 7 months ago (2012-05-18 20:03:07 UTC) #5 
In addition is fine by me: LGTM

Powered by Google App Engine
This is Rietveld 408576698