Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 10388197: Coverity: Fix a pass-by-value. (Closed)

Created:
8 years, 7 months ago by James Hawkins
Modified:
8 years, 7 months ago
Reviewers:
groby-ooo-7-16, aa
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Coverity: Fix a pass-by-value. CID_COUNT=1 CID=104029 BUG=none TEST=none R=groby TBR=aa Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137930

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/extension_menu_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
8 years, 7 months ago (2012-05-18 17:50:10 UTC) #1
groby-ooo-7-16
I have the same fix in https://chromiumcodereview.appspot.com/10408019/ :) In the interest of expediency, LGTM
8 years, 7 months ago (2012-05-18 18:09:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10388197/1
8 years, 7 months ago (2012-05-18 18:11:13 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-18 19:46:07 UTC) #4
Change committed as 137930

Powered by Google App Engine
This is Rietveld 408576698