Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1917)

Unified Diff: chrome/browser/managed_mode_unittest.cc

Issue 10388186: RefCounted types should not have public destructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/managed_mode_unittest.cc
diff --git a/chrome/browser/managed_mode_unittest.cc b/chrome/browser/managed_mode_unittest.cc
index 712dcc7f8b063d05e9737abb3dfc2a946fdd4b93..7beee9fac9ea232ae49938bd5d57d5fabb189ba9 100644
--- a/chrome/browser/managed_mode_unittest.cc
+++ b/chrome/browser/managed_mode_unittest.cc
@@ -94,7 +94,6 @@ class MockCallback : public base::RefCountedThreadSafe<MockCallback> {
explicit MockCallback(FakeManagedMode* managed_mode)
: managed_mode_(managed_mode) {
}
- virtual ~MockCallback() {}
void CheckManagedMode(bool success) {
EXPECT_EQ(managed_mode_->IsInManagedModeImpl(), success);
@@ -103,7 +102,12 @@ class MockCallback : public base::RefCountedThreadSafe<MockCallback> {
MOCK_METHOD1(DidEnterManagedMode, void(bool));
+ protected:
+ virtual ~MockCallback() {}
+
private:
+ friend class base::RefCountedThreadSafe<MockCallback>;
+
FakeManagedMode* managed_mode_;
DISALLOW_COPY_AND_ASSIGN(MockCallback);
« no previous file with comments | « chrome/browser/extensions/extension_record_api.h ('k') | chrome/browser/password_manager/password_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698