Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: chrome/browser/extensions/extension_record_api.h

Issue 10388186: RefCounted types should not have public destructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/usb/usb_api.h ('k') | chrome/browser/managed_mode_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_record_api.h
diff --git a/chrome/browser/extensions/extension_record_api.h b/chrome/browser/extensions/extension_record_api.h
index afd6cfd34e800c317beef24a3c653c7f4c1f209c..e7ad077fe366c3b9a4e906b57f22d86f630b53be 100644
--- a/chrome/browser/extensions/extension_record_api.h
+++ b/chrome/browser/extensions/extension_record_api.h
@@ -51,13 +51,7 @@ class ProductionProcessStrategy : public ProcessStrategy {
// file. This base class encapslates those common elements.
class RunPageCyclerFunction : public AsyncExtensionFunction {
public:
-
explicit RunPageCyclerFunction(ProcessStrategy* strategy);
- virtual ~RunPageCyclerFunction();
-
- // Gather common page cycler parameters and store them, then do blocking
- // thread invocation of RunTestBrowser.
- virtual bool RunImpl() OVERRIDE;
// Make a CommandLine copy of |original|, removing all switches in
// |to_remove|.
@@ -68,6 +62,12 @@ class RunPageCyclerFunction : public AsyncExtensionFunction {
virtual const ProcessStrategy &GetProcessStrategy();
protected:
+ virtual ~RunPageCyclerFunction();
+
+ // Gather common page cycler parameters and store them, then do blocking
+ // thread invocation of RunTestBrowser.
+ virtual bool RunImpl() OVERRIDE;
+
// Parse the JS parameters, and store them as member data.
virtual bool ParseJSParameters() = 0;
@@ -101,6 +101,8 @@ class RunPageCyclerFunction : public AsyncExtensionFunction {
class CaptureURLsFunction : public RunPageCyclerFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.record.captureURLs");
+
CaptureURLsFunction();
explicit CaptureURLsFunction(ProcessStrategy* strategy);
@@ -115,12 +117,12 @@ class CaptureURLsFunction : public RunPageCyclerFunction {
// Return error list.
virtual void Finish() OVERRIDE;
-
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.record.captureURLs");
};
class ReplayURLsFunction : public RunPageCyclerFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.record.replayURLs");
+
ReplayURLsFunction();
explicit ReplayURLsFunction(ProcessStrategy* strategy);
@@ -139,8 +141,6 @@ class ReplayURLsFunction : public RunPageCyclerFunction {
// Return error list, statistical results, and runtime.
virtual void Finish() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.record.replayURLs");
-
// These three data are additional information added to the sub-browser
// commandline.
int repeat_count_;
« no previous file with comments | « chrome/browser/extensions/api/usb/usb_api.h ('k') | chrome/browser/managed_mode_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698