Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: chrome/browser/prerender/prerender_local_predictor.cc

Issue 10388186: RefCounted types should not have public destructors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_local_predictor.cc
diff --git a/chrome/browser/prerender/prerender_local_predictor.cc b/chrome/browser/prerender/prerender_local_predictor.cc
index daffaee12216a73bc461fd4dfb2de824976b5711..ba16e8bd0502032c67611d2aabdebe005629f7de 100644
--- a/chrome/browser/prerender/prerender_local_predictor.cc
+++ b/chrome/browser/prerender/prerender_local_predictor.cc
@@ -26,19 +26,24 @@ class GetURLForURLIDTask : public HistoryDBTask {
url_id_(url_id),
success_(false) {
}
+
virtual bool RunOnDBThread(history::HistoryBackend* backend,
- history::HistoryDatabase* db) {
+ history::HistoryDatabase* db) OVERRIDE {
history::URLRow url_row;
success_ = db->GetURLRow(url_id_, &url_row);
if (success_)
url_ = url_row.url();
return true;
}
- virtual void DoneRunOnMainThread() {
+
+ virtual void DoneRunOnMainThread() OVERRIDE {
if (success_)
local_predictor_->OnLookupURL(url_id_, url_);
}
+
private:
+ virtual ~GetURLForURLIDTask() {}
+
PrerenderLocalPredictor* local_predictor_;
history::URLID url_id_;
bool success_;
@@ -55,15 +60,20 @@ class GetVisitHistoryTask : public HistoryDBTask {
max_visits_(max_visits),
visit_history_(new std::vector<history::BriefVisitInfo>) {
}
+
virtual bool RunOnDBThread(history::HistoryBackend* backend,
- history::HistoryDatabase* db) {
+ history::HistoryDatabase* db) OVERRIDE {
db->GetBriefVisitInfoOfMostRecentVisits(max_visits_, visit_history_.get());
return true;
}
- virtual void DoneRunOnMainThread() {
+
+ virtual void DoneRunOnMainThread() OVERRIDE {
local_predictor_->OnGetInitialVisitHistory(visit_history_.Pass());
}
+
private:
+ virtual ~GetVisitHistoryTask() {}
+
PrerenderLocalPredictor* local_predictor_;
int max_visits_;
scoped_ptr<std::vector<history::BriefVisitInfo> > visit_history_;
« no previous file with comments | « chrome/browser/password_manager/password_store_unittest.cc ('k') | chrome/renderer/spellchecker/spellcheck.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698