Fix the keyboard overlay not working.

Fix the keyboard overlay not working.

Fix the regression of the keyboard overlay caused by the following CL.
https://src.chromium.org/viewvc/chrome?view=rev&revision=137067

BUG=128489
TEST=Manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137767

[xiyuan, 2012-05-17 16:14:42]

lgtm

[Evan Stade, 2012-05-17 16:28:51]

sorry for the breakage :(

by the way, this is the first time I've noticed there are two, seemingly
unrelated files called keyboard_overlay.html. Somewhat confusing imo.

http://codereview.chromium.org/10388182/diff/1/chrome/browser/resources/chrom...
File chrome/browser/resources/chromeos/keyboard_overlay.html (left):

http://codereview.chromium.org/10388182/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/keyboard_overlay.html:12: <script
src="chrome://resources/js/util.js"></script>
don't you need to add i18n_template2.js? otherwise how does the title get
populated?

[mazda, 2012-05-17 17:11:21]

> by the way, this is the first time I've noticed there are two, seemingly
> unrelated files called keyboard_overlay.html. Somewhat confusing imo.

This file predates the other one. The other one is for showing a modifier key
settings page, and accidentally renamed to the same name.
I think the other one should be renamed to a different name.

http://codereview.chromium.org/10388182/diff/1/chrome/browser/resources/chrom...
File chrome/browser/resources/chromeos/keyboard_overlay.html (left):

http://codereview.chromium.org/10388182/diff/1/chrome/browser/resources/chrom...
chrome/browser/resources/chromeos/keyboard_overlay.html:12: <script
src="chrome://resources/js/util.js"></script>
On 2012/05/17 16:28:51, Evan Stade wrote:
> don't you need to add i18n_template2.js? otherwise how does the title get
> populated?

Done. Thanks.

[Evan Stade, 2012-05-17 18:21:45]

lgtm

http://codereview.chromium.org/10388182/diff/2002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/keyboard_overlay.html (right):

http://codereview.chromium.org/10388182/diff/2002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/keyboard_overlay.html:10: <script
src="chrome://resources/js/util.js"></script>
put strings and template at the bottom (where you deleted the other lines from).
load_time_data and util should stay here.

[mazda, 2012-05-17 19:34:51]

http://codereview.chromium.org/10388182/diff/2002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/keyboard_overlay.html (right):

http://codereview.chromium.org/10388182/diff/2002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/keyboard_overlay.html:10: <script
src="chrome://resources/js/util.js"></script>
On 2012/05/17 18:21:45, Evan Stade wrote:
> put strings and template at the bottom (where you deleted the other lines
from).
> load_time_data and util should stay here.

Done.
For future reference, could I ask what rule is used to order script tags?

[commit-bot: I haz the power, 2012-05-17 20:50:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10388182/7001

[commit-bot: I haz the power, 2012-05-17 23:14:46]

Change committed as 137767