Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10388181: Remove virtual keyboard support from input_method_descriptor.h. (Closed)

Created:
8 years, 7 months ago by Yusuke Sato
Modified:
8 years, 7 months ago
Reviewers:
csilv, Zachary Kuznia
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove virtual keyboard support from input_method_descriptor.h. Since we've removed VK support (crrev.com/138223), now we can simplify InputMethodDescriptor. BUG=128295 TEST=try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138709

Patch Set 1 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -131 lines) Patch
M chrome/browser/chromeos/input_method/ibus_ui_controller_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_descriptor.h View 4 chunks +4 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_descriptor.cc View 5 chunks +5 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_descriptor_unittest.cc View 2 chunks +1 line, -31 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_whitelist.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_whitelist.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_whitelist_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
8 years, 7 months ago (2012-05-23 04:24:06 UTC) #1
Zachary Kuznia
lgtm
8 years, 7 months ago (2012-05-23 04:32:09 UTC) #2
Yusuke Sato
+csilv Could you review chrome/browser/ui/webui/options2/language_options_handler2_unittest.cc?
8 years, 7 months ago (2012-05-23 05:12:21 UTC) #3
csilv
language_options_handler2_unittest.cc LGTM
8 years, 7 months ago (2012-05-23 17:22:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10388181/7001
8 years, 7 months ago (2012-05-23 22:47:41 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-24 02:21:02 UTC) #6
Change committed as 138709

Powered by Google App Engine
This is Rietveld 408576698