Issue 10388178: Disable retrieving suggestions in the background.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388178: Disable retrieving suggestions in the background. (Closed)

Created:
8 years, 7 months ago by Hironori Bono

Modified:
8 years, 7 months ago

Reviewers:
Hajime Morrita

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disable retrieving suggestions in the background. This change disables retrieving suggestions for misspelled words automatically because it consumes lots of CPU power, especially when we paste a long word such as function names. (It is an overkill to retrieve them.) BUG=126249 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137831

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/renderer/spellchecker/spellcheck.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hajime Morrita

8 years, 7 months ago (2012-05-17 08:09:29 UTC) #2

lgtm. Thanks for fixing this.
I didn't realized that suggestion lookup is such slow...

Expand Messages | Collapse Messages