Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10388175: Remove all the unnused automation IPCs. These were used by UI tests that have been converted to bro… (Closed)

Created:
8 years, 7 months ago by jam
Modified:
8 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, robertshield, kkania
Visibility:
Public.

Description

Remove all the unnused automation IPCs. These were used by UI tests that have been converted to browser_tests. BUG=121574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137593

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1784 lines) Patch
M chrome/browser/automation/automation_provider_observers.h View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_resource_message_filter.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/automation/automation_tab_tracker.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_tab_tracker.cc View 4 chunks +0 lines, -31 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 10 chunks +0 lines, -117 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 22 chunks +1 line, -564 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_aura.cc View 2 chunks +0 lines, -58 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_gtk.cc View 3 chunks +0 lines, -39 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_mac.mm View 3 chunks +0 lines, -68 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_win.cc View 3 chunks +0 lines, -59 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 36 chunks +47 lines, -47 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 4 chunks +0 lines, -36 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 5 chunks +0 lines, -71 lines 0 comments Download
M chrome/test/automation/browser_proxy.h View 4 chunks +0 lines, -46 lines 0 comments Download
M chrome/test/automation/browser_proxy.cc View 5 chunks +0 lines, -132 lines 0 comments Download
M chrome/test/automation/tab_proxy.h View 5 chunks +0 lines, -69 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 7 chunks +0 lines, -184 lines 0 comments Download
M chrome/test/automation/window_proxy.h View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/test/automation/window_proxy.cc View 5 chunks +0 lines, -90 lines 0 comments Download
M chrome/test/ui/ui_test.h View 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 3 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 7 months ago (2012-05-16 23:45:58 UTC) #1
jam
I'll delete these IPCs in a followup change.
8 years, 7 months ago (2012-05-16 23:46:17 UTC) #2
Elliot Glaysher
8 years, 7 months ago (2012-05-16 23:52:32 UTC) #3 
I liked the part where you deleted all the code. lgtm

Powered by Google App Engine
This is Rietveld 408576698