Construct a TCW for the login view's WebView.

Construct a TCW for the login view's WebView.
It needs this for Password Manager. It could be that we could just construct the Password Manager for this type, but this is the simplest fix.

http://crbug.com/127110
TEST=See bug, configure proxy with auth required and open GAIA frame at sign in screen.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137512

[Avi (use Gerrit), 2012-05-16 17:28:10]

On 2012/05/16 17:25:37, Ben Goodger (Google) wrote:

I'm a little concerned about this; TCWs have a _lot_ more in them than just the
password manager. If this works for you, fine, but I'd feel more comfortable if
you just instantiated what you needed.

[Ben Goodger (Google), 2012-05-16 17:39:50]

On 2012/05/16 17:28:10, Avi wrote:
> I'm a little concerned about this; TCWs have a _lot_ more in them than just
the
> password manager. If this works for you, fine, but I'd feel more comfortable
if
> you just instantiated what you needed.

I agree. This code used to use DOMView, which used a TCW. It turns out it was
implicitly getting password manager functionality (and even more implicitly some
autofill functionality) from TCW. We have a high level cleanup action item to
move cros UI components like login out of src/chrome. We will have to address
this in detail to complete this task. It may be the case that Password Manager
needs to become a top level component to support this.

[Nikita (slow), 2012-05-16 17:44:18]

lgtm, tested on fresh checkout with instructions
https://sites.google.com/a/google.com/cros-connectivity-testing/proxy-testing

This need to be merged into M20 (P0 beta blocker) so such solution is ok.

[commit-bot: I haz the power, 2012-05-16 17:45:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ben@chromium.org/10388166/3002

[commit-bot: I haz the power, 2012-05-16 21:17:29]

Change committed as 137512