Issue 10388164: Disable optimization for functions that have scopes that cannot be reconstructed from the context c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388164: Disable optimization for functions that have scopes that cannot be reconstructed from the context c… (Closed)

Created:
8 years, 7 months ago by ulan

Modified:
8 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Disable optimization for functions that have scopes that cannot be reconstructed from the context chain. BUG=v8:2071 TEST=mjsunit/regress/regress-2071.js Committed: https://code.google.com/p/v8/source/detail?r=11592

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -5 lines)			Patch
M	src/compiler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/full-codegen.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/scopes.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	src/scopes.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-2071.js	View	1	1 chunk	+79 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 7 months ago (2012-05-18 09:09:18 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/10388164/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-2071.js (right):

https://chromiumcodereview.appspot.com/10388164/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-2071.js:35: print(b);
nit: is this print() statement needed?

https://chromiumcodereview.appspot.com/10388164/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-2071.js:42: for(var i = 0; i < 10000; i++) {
nit: I think 1000 iterations is enough. Let's let the test suite run a little
faster :-)

Expand Messages | Collapse Messages