Issue 10388156: Adding the flip windows button to the browser window

Issue 10388156: Adding the flip windows button to the browser window (Closed)

Created:
8 years, 7 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 7 months ago

Reviewers:
ananta, sky

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Adding the flip windows button to the browser window -This is for metro mode -The image is a placeholder, image to be provided later BUG=127489 TEST=see the bug for details. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137544

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -3 lines)			Patch
M	chrome/browser/ui/views/frame/browser_frame_win.h	View	1	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_frame_win.cc	View	1 2	4 chunks	+30 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.cc	View	1	3 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

the button thingy. http://codereview.chromium.org/10388156/diff/1/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (right): http://codereview.chromium.org/10388156/diff/1/chrome/browser/ui/views/frame/browser_view.cc#newcode1823 chrome/browser/ui/views/frame/browser_view.cc:1823: IDR_PAGEINFO_WARNING_MINOR)); the asset is a placeholder ...

8 years, 7 months ago (2012-05-16 01:31:36 UTC) #1

sky

http://codereview.chromium.org/10388156/diff/1/chrome/browser/ui/views/frame/browser_view.cc File chrome/browser/ui/views/frame/browser_view.cc (right): http://codereview.chromium.org/10388156/diff/1/chrome/browser/ui/views/frame/browser_view.cc#newcode1764 chrome/browser/ui/views/frame/browser_view.cc:1764: void BrowserView::ButtonPressed(views::Button* sender, Can you move all of this ...

8 years, 7 months ago (2012-05-16 04:31:37 UTC) #2

sky

8 years, 7 months ago (2012-05-16 21:34:52 UTC) #4

LGTM

http://codereview.chromium.org/10388156/diff/5002/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_frame_win.cc (right):

http://codereview.chromium.org/10388156/diff/5002/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_frame_win.cc:80:
switcher_button->SetVisible(true);
SetVisible(true) and SetBounds shouldn't be necessary.

Expand Messages | Collapse Messages