Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 10388146: Fix crash in Android content_shell startup (Closed)

Created:
8 years, 7 months ago by John Knottenbelt
Modified:
8 years, 7 months ago
Reviewers:
John Grabowski, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Fix crash in Android content_shell startup Pass in the delegate to ContentMainRunner::Initialize so that it can invoke the relevant startup routines. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M content/app/content_main_runner.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/shell/android/shell_library_loader.cc View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
John Knottenbelt
8 years, 7 months ago (2012-05-15 16:40:28 UTC) #1
John Grabowski
LGTM !
8 years, 7 months ago (2012-05-15 16:48:46 UTC) #2
jam
lgtm
8 years, 7 months ago (2012-05-15 16:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10388146/1
8 years, 7 months ago (2012-05-15 16:58:05 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 20:01:16 UTC) #5
Change committed as 137215

Powered by Google App Engine
This is Rietveld 408576698