Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 10388145: Fix acceptance of multiple mime types in the Mac file picker. (Closed)

Created:
8 years, 7 months ago by Avi (use Gerrit)
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Fix acceptance of multiple mime types in the Mac file picker. This mostly reverts r135025 and does it correctly based on how it really works. BUG=127749 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137162

Patch Set 1 #

Total comments: 2

Patch Set 2 : helper function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M chrome/browser/ui/cocoa/select_file_dialog_mac.mm View 1 3 chunks +30 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
You reviewed the first version, so you get this one.
8 years, 7 months ago (2012-05-15 15:24:47 UTC) #1
Nico
lgtm https://chromiumcodereview.appspot.com/10388145/diff/1/chrome/browser/ui/cocoa/select_file_dialog_mac.mm File chrome/browser/ui/cocoa/select_file_dialog_mac.mm (right): https://chromiumcodereview.appspot.com/10388145/diff/1/chrome/browser/ui/cocoa/select_file_dialog_mac.mm#newcode228 chrome/browser/ui/cocoa/select_file_dialog_mac.mm:228: NSString* type_extension = base::SysUTF8ToNSString(ext_list[j]); nit: it might be ...
8 years, 7 months ago (2012-05-15 15:38:50 UTC) #2
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/10388145/diff/1/chrome/browser/ui/cocoa/select_file_dialog_mac.mm File chrome/browser/ui/cocoa/select_file_dialog_mac.mm (right): https://chromiumcodereview.appspot.com/10388145/diff/1/chrome/browser/ui/cocoa/select_file_dialog_mac.mm#newcode228 chrome/browser/ui/cocoa/select_file_dialog_mac.mm:228: NSString* type_extension = base::SysUTF8ToNSString(ext_list[j]); On 2012/05/15 15:38:50, Nico wrote: ...
8 years, 7 months ago (2012-05-15 15:54:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10388145/2002
8 years, 7 months ago (2012-05-15 16:03:50 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-15 17:35:33 UTC) #5
Change committed as 137162

Powered by Google App Engine
This is Rietveld 408576698