Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10388131: Allow GLES2CmdDecoder to change the GLSurface associated with the default FBO. (Closed)

Created:
8 years, 7 months ago by apatrick_chromium
Modified:
8 years, 7 months ago
Reviewers:
greggman
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, apatrick_chromium, dhollowa+watch_chromium.org
Visibility:
Public.

Description

Allow GLES2CmdDecoder to change the GLSurface associated with the default FBO. This is part 1. It can't actually be used yet because there are assumptions that the surface never changed. It is intended to allow each renderer process to create only one command buffer for use by the compositor while being able to switch the surface between different windows, for examnple if a single renderer process handles multiple tabs of the same site. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137693

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -49 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A gpu/command_buffer/service/gl_surface_mock.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gl_surface_mock.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 10 chunks +27 lines, -28 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M gpu/demos/demos.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/demos/framework/window.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M gpu/gpu_common.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 2 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apatrick_chromium
8 years, 7 months ago (2012-05-16 23:52:57 UTC) #1
greggman
8 years, 7 months ago (2012-05-17 00:05:44 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698