Fixes the naming in the About page of CrOS.

Fixes the naming in the About page of CrOS.

Introduces a new constant IDS_SHORT_PRODUCT_OS_NAME (i.e., Chrome OS), and changes the old constant IDS_PRODUCT_OS_NAME to be the full name (i.e., Google Chrome OS) to remain in sync with the other string names. Changes previous references to IDS_PRODUCT_OS_NAME to IDS_SHORT_PRODUCT_OS_NAME.

BUG=122645
TEST=look at help page on CrOS and see that text says Google Chrome OS


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137195

[Kyle Horimoto, 2012-05-14 20:03:35]

jhawkins: Need review for chrome/common/chrome_version_info.cc
estade: Need review for chrome/browser/ui/webui/*
cpu: Need review for chrome/app/*
ben: Need review for chrome/browser/ui/views/update_recommended_message_box.cc
avayvod: Need review for chrome/browser/chromeos/login/*

[James Hawkins, 2012-05-14 20:10:45]

my file LGTM

[cpu_(ooo_6.6-7.5), 2012-05-14 21:05:25]

my file lgtm

[Evan Stade, 2012-05-14 22:53:48]

webui lgtm

https://chromiumcodereview.appspot.com/10388120/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/uber/uber_ui.cc (right):

https://chromiumcodereview.appspot.com/10388120/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/uber/uber_ui.cc:94: // TODO(jhawkins): Attempt to get
rid of IDS_SHORT_PRODUCT_OS_NAME.
I'm not sure what this means

[Kyle Horimoto, 2012-05-14 23:03:23]

https://chromiumcodereview.appspot.com/10388120/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/uber/uber_ui.cc (right):

https://chromiumcodereview.appspot.com/10388120/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/uber/uber_ui.cc:94: // TODO(jhawkins): Attempt to get
rid of IDS_SHORT_PRODUCT_OS_NAME.
On 2012/05/14 22:53:48, Evan Stade wrote:
> I'm not sure what this means

Not sure either - it was already here, so I just updated the string name I
changed.

[Nikita (slow), 2012-05-15 10:23:17]

chromeos/login lgtm

[Ben Goodger (Google), 2012-05-15 16:08:17]

LGTM for ui/views. note that for rote changes like this you can just tbr owners
in that area.

[commit-bot: I haz the power, 2012-05-15 17:05:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10388120/1

[commit-bot: I haz the power, 2012-05-15 19:01:53]

Change committed as 137195