Issue 10388107: [chromeos] Fix Logout automation when no browser windows are present.

Issue 10388107: [chromeos] Fix Logout automation when no browser windows are present. (Closed)

Created:
8 years, 7 months ago by Nirnimesh

Modified:
8 years, 7 months ago

Reviewers:
dennis_jeffrey, sadrul

CC:
chromium-reviews, Nirnimesh, kkania, anantha, robertshield, dyu1, dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromeos] Fix Logout automation when no browser windows are present. Logout automation used to apply the IDC_EXIT accelerator to the first browser window. This would not work in the case of aura if no browser windows are present. Fix automation to use ash system tray calls. BUG=chromium:127859 TEST=new pyauto test: chromeos_login.ChromeosLogin.testLogoutWithNoWindows R=sadrul@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137078

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -6 lines)			Patch
M	chrome/browser/automation/testing_automation_provider.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider_chromeos.cc	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/test/functional/chromeos_login.py	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/test/pyautolib/pyauto.py	View	1	1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

LGTM with 1 nit http://codereview.chromium.org/10388107/diff/4001/chrome/test/functional/chromeos_login.py File chrome/test/functional/chromeos_login.py (right): http://codereview.chromium.org/10388107/diff/4001/chrome/test/functional/chromeos_login.py#newcode170 chrome/test/functional/chromeos_login.py:170: add 1 more blank line ...

8 years, 7 months ago (2012-05-15 00:04:25 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nirnimesh@chromium.org/10388107/7

8 years, 7 months ago (2012-05-15 02:18:46 UTC) #6

Change committed as 137078

Expand Messages | Collapse Messages