Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 10388105: aura: Fix a couple of bug (really the same bug at two different places) for drag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_aura.cc
diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
index 2971c365a1bfb1bddb53d2403bb96523e7e6f2d8..ff14d3a2e8fe3773aed984703818db4839d49831 100644
--- a/content/browser/web_contents/web_contents_view_aura.cc
+++ b/content/browser/web_contents/web_contents_view_aura.cc
@@ -179,7 +179,8 @@ WebContentsViewAura::WebContentsViewAura(
delegate_(delegate),
current_drag_op_(WebKit::WebDragOperationNone),
close_tab_after_drag_ends_(false),
- drag_dest_delegate_(NULL) {
+ drag_dest_delegate_(NULL),
+ current_rvh_for_drag_(NULL) {
}
WebContentsViewAura::~WebContentsViewAura() {
@@ -583,6 +584,7 @@ void WebContentsViewAura::OnDragEntered(const aura::DropTargetEvent& event) {
gfx::Point screen_pt =
GetNativeView()->GetRootWindow()->last_mouse_location();
+ current_rvh_for_drag_ = web_contents_->GetRenderViewHost();
web_contents_->GetRenderViewHost()->DragTargetDragEnter(
drop_data, event.location(), screen_pt, op);
@@ -593,6 +595,10 @@ void WebContentsViewAura::OnDragEntered(const aura::DropTargetEvent& event) {
}
int WebContentsViewAura::OnDragUpdated(const aura::DropTargetEvent& event) {
+ DCHECK(current_rvh_for_drag_);
+ if (current_rvh_for_drag_ != web_contents_->GetRenderViewHost())
+ OnDragEntered(event);
+
WebKit::WebDragOperationsMask op = ConvertToWeb(event.source_operations());
gfx::Point screen_pt =
GetNativeView()->GetRootWindow()->last_mouse_location();
@@ -606,12 +612,20 @@ int WebContentsViewAura::OnDragUpdated(const aura::DropTargetEvent& event) {
}
void WebContentsViewAura::OnDragExited() {
+ DCHECK(current_rvh_for_drag_);
+ if (current_rvh_for_drag_ != web_contents_->GetRenderViewHost())
+ return;
+
web_contents_->GetRenderViewHost()->DragTargetDragLeave();
if (drag_dest_delegate_)
drag_dest_delegate_->OnDragLeave();
}
int WebContentsViewAura::OnPerformDrop(const aura::DropTargetEvent& event) {
+ DCHECK(current_rvh_for_drag_);
+ if (current_rvh_for_drag_ != web_contents_->GetRenderViewHost())
+ OnDragEntered(event);
+
web_contents_->GetRenderViewHost()->DragTargetDrop(
event.location(),
GetNativeView()->GetRootWindow()->last_mouse_location());

Powered by Google App Engine
This is Rietveld 408576698