Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: lib/dom/scripts/systemhtml.py

Issue 10388084: Better support for the case of typed arrays inheriting from other typed arrays. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebaseline Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/dom/scripts/systemhtml.py
diff --git a/lib/dom/scripts/systemhtml.py b/lib/dom/scripts/systemhtml.py
index a9e4a349f528dab6fc664783c8954cf3b8c14500..034347469e678131c27e89e682ba0cbfa8adff7d 100644
--- a/lib/dom/scripts/systemhtml.py
+++ b/lib/dom/scripts/systemhtml.py
@@ -605,10 +605,10 @@ class HtmlInterfacesSystem(HtmlSystem):
template = self._templates.Load('interface.darttemplate')
return HtmlDartInterfaceGenerator(
- interface, dart_interface_code,
+ self, interface, dart_interface_code,
template,
common_prefix, super_interface_name,
- source_filter, self, self._shared)
+ source_filter, self._shared)
def ProcessCallback(self, interface, info):
"""Generates a typedef for the callback interface."""
@@ -633,11 +633,10 @@ class HtmlInterfacesSystem(HtmlSystem):
class HtmlDartInterfaceGenerator(DartInterfaceGenerator):
"""Generates Dart Interface definition for one DOM IDL interface."""
- def __init__(self, interface, emitter, template,
- common_prefix, super_interface, source_filter, system, shared):
- super(HtmlDartInterfaceGenerator, self).__init__(interface,
+ def __init__(self, system, interface, emitter, template,
+ common_prefix, super_interface, source_filter, shared):
+ super(HtmlDartInterfaceGenerator, self).__init__(system, interface,
emitter, template, common_prefix, super_interface, source_filter)
- self._system = system
self._shared = shared
def StartInterface(self):
@@ -696,7 +695,8 @@ class HtmlDartInterfaceGenerator(DartInterfaceGenerator):
CTOR=typename,
PARAMS=constructor_info.ParametersInterfaceDeclaration());
- element_type = MaybeTypedArrayElementType(self._interface)
+ element_type = MaybeTypedArrayElementTypeInHierarchy(
+ self._interface, self._system._database)
if element_type:
self._members_emitter.Emit(
'\n'
@@ -1527,6 +1527,9 @@ class HtmlDartiumInterfaceGenerator(object):
template = self._system._templates.Load(template_file)
self._members_emitter.Emit(template, E=DartType(element_type))
+ def AmendIndexer(self, element_type):
+ pass
+
def _HasNativeIndexGetter(self, interface):
return ('IndexedGetter' in interface.ext_attrs or
'NumericIndexedGetter' in interface.ext_attrs)

Powered by Google App Engine
This is Rietveld 408576698