Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: base/callback_internal.cc

Issue 10388060: Make Callback.Reset safe against deleting itself. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review changes Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | base/callback_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/callback_internal.h" 5 #include "base/callback_internal.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8
9 namespace base { 9 namespace base {
10 namespace internal { 10 namespace internal {
11 11
12 bool CallbackBase::is_null() const { 12 bool CallbackBase::is_null() const {
13 return bind_state_.get() == NULL; 13 return bind_state_.get() == NULL;
14 } 14 }
15 15
16 void CallbackBase::Reset() { 16 void CallbackBase::Reset() {
17 polymorphic_invoke_ = NULL;
18 // NULL the bind_state_ last, since it may be holding the last ref to whatever
19 // object owns us, and we may be deleted after that.
17 bind_state_ = NULL; 20 bind_state_ = NULL;
18 polymorphic_invoke_ = NULL;
19 } 21 }
20 22
21 bool CallbackBase::Equals(const CallbackBase& other) const { 23 bool CallbackBase::Equals(const CallbackBase& other) const {
22 return bind_state_.get() == other.bind_state_.get() && 24 return bind_state_.get() == other.bind_state_.get() &&
23 polymorphic_invoke_ == other.polymorphic_invoke_; 25 polymorphic_invoke_ == other.polymorphic_invoke_;
24 } 26 }
25 27
26 CallbackBase::CallbackBase(BindStateBase* bind_state) 28 CallbackBase::CallbackBase(BindStateBase* bind_state)
27 : bind_state_(bind_state), 29 : bind_state_(bind_state),
28 polymorphic_invoke_(NULL) { 30 polymorphic_invoke_(NULL) {
29 DCHECK(!bind_state_ || bind_state_->HasOneRef()); 31 DCHECK(!bind_state_ || bind_state_->HasOneRef());
30 } 32 }
31 33
32 CallbackBase::~CallbackBase() { 34 CallbackBase::~CallbackBase() {
33 } 35 }
34 36
35 } // namespace base 37 } // namespace base
36 } // namespace internal 38 } // namespace internal
OLDNEW
« no previous file with comments | « no previous file | base/callback_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698