Issue 10388055: Revert 132543 - Use the non-localized "canonical name" of an extension to write to its sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388055: Revert 132543 - Use the non-localized "canonical name" of an extension to write to its sync (Closed)

Created:
8 years, 7 months ago by dharani1

Modified:
8 years, 7 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1130/src/

Visibility:
Public.

Revert 132543 - Use the non-localized "canonical name" of an extension to write to its sync data, rather than the localized name. BUG=123214 TEST=none Review URL: http://codereview.chromium.org/10086019 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136121

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -7 lines)			Patch
M	chrome/browser/extensions/extension_sync_data.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/extension.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

not at google - send to devlin

8 years, 7 months ago (2012-05-09 23:26:17 UTC) #2

Are you sure this is what is causing the issue?  Cos this reverts a P1 bug fix.