Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: test/mjsunit/override-read-only-property.js

Issue 10388047: Implement correct checking for inherited readonliness on assignment. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Michael's comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/harmony/proxies.js ('k') | test/mjsunit/readonly.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 20 matching lines...) Expand all
31 // 31 //
32 // However, for compatibility with WebKit/JSC, we allow the overriding 32 // However, for compatibility with WebKit/JSC, we allow the overriding
33 // of read-only properties in prototype chains. 33 // of read-only properties in prototype chains.
34 34
35 function F() {}; 35 function F() {};
36 F.prototype = Number; 36 F.prototype = Number;
37 37
38 var original_number_max = Number.MAX_VALUE; 38 var original_number_max = Number.MAX_VALUE;
39 39
40 // Assignment to a property which does not exist on the object itself, 40 // Assignment to a property which does not exist on the object itself,
41 // but is read-only in a prototype takes effect. 41 // but is read-only in a prototype does not take effect.
42 var f = new F(); 42 var f = new F();
43 assertEquals(original_number_max, f.MAX_VALUE); 43 assertEquals(original_number_max, f.MAX_VALUE);
44 f.MAX_VALUE = 42; 44 f.MAX_VALUE = 42;
45 assertEquals(42, f.MAX_VALUE); 45 assertEquals(original_number_max, f.MAX_VALUE);
46 46
47 // Assignment to a property which does not exist on the object itself, 47 // Assignment to a property which does not exist on the object itself,
48 // but is read-only in a prototype takes effect. 48 // but is read-only in a prototype does not take effect.
49 f = new F(); 49 f = new F();
50 with (f) { 50 with (f) {
51 MAX_VALUE = 42; 51 MAX_VALUE = 42;
52 } 52 }
53 assertEquals(42, f.MAX_VALUE); 53 assertEquals(original_number_max, f.MAX_VALUE);
54 54
55 // Assignment to read-only property on the object itself is ignored. 55 // Assignment to read-only property on the object itself is ignored.
56 Number.MAX_VALUE = 42; 56 Number.MAX_VALUE = 42;
57 assertEquals(original_number_max, Number.MAX_VALUE); 57 assertEquals(original_number_max, Number.MAX_VALUE);
58 58
59 // G should be read-only on the global object and the assignment is 59 // G should be read-only on the global object and the assignment is
60 // ignored. 60 // ignored.
61 (function G() { 61 (function G() {
62 eval("G = 42;"); 62 eval("G = 42;");
63 assertTrue(typeof G === 'function'); 63 assertTrue(typeof G === 'function');
64 })(); 64 })();
OLDNEW
« no previous file with comments | « test/mjsunit/harmony/proxies.js ('k') | test/mjsunit/readonly.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698