Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10388034: Disables the ability to tab to navigation items when an overlay is displayed. (Closed)

Created:
8 years, 7 months ago by Kyle Horimoto
Modified:
8 years, 7 months ago
Reviewers:
dmazzoni, Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Disables the ability to tab to navigation items when an overlay is displayed. BUG=113337 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136502

Patch Set 1 #

Patch Set 2 : Set aria-hidden=true when navigation is behind an overlay #

Total comments: 2

Patch Set 3 : Piggybacks beginInterceptingEvents() #

Total comments: 2

Patch Set 4 : Simplifies navigation tabbing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/uber/uber.js View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Kyle Horimoto
8 years, 7 months ago (2012-05-08 20:57:58 UTC) #1
Evan Stade
https://chromiumcodereview.appspot.com/10388034/diff/3001/chrome/browser/resources/options2/options_page.js File chrome/browser/resources/options2/options_page.js (right): https://chromiumcodereview.appspot.com/10388034/diff/3001/chrome/browser/resources/options2/options_page.js#newcode259 chrome/browser/resources/options2/options_page.js:259: uber.invokeMethodOnParent('disableNavigationItemTabbing'); this shouldn't be necessary. Just piggy back on ...
8 years, 7 months ago (2012-05-08 23:22:59 UTC) #2
Kyle Horimoto
https://chromiumcodereview.appspot.com/10388034/diff/3001/chrome/browser/resources/options2/options_page.js File chrome/browser/resources/options2/options_page.js (right): https://chromiumcodereview.appspot.com/10388034/diff/3001/chrome/browser/resources/options2/options_page.js#newcode259 chrome/browser/resources/options2/options_page.js:259: uber.invokeMethodOnParent('disableNavigationItemTabbing'); On 2012/05/08 23:23:00, Evan Stade wrote: > this ...
8 years, 7 months ago (2012-05-08 23:44:18 UTC) #3
Evan Stade
https://chromiumcodereview.appspot.com/10388034/diff/5003/chrome/browser/resources/uber/uber.js File chrome/browser/resources/uber/uber.js (right): https://chromiumcodereview.appspot.com/10388034/diff/5003/chrome/browser/resources/uber/uber.js#newcode339 chrome/browser/resources/uber/uber.js:339: function setNavigationItemTabbing(enabled) { I don't think this function is ...
8 years, 7 months ago (2012-05-08 23:51:31 UTC) #4
Kyle Horimoto
https://chromiumcodereview.appspot.com/10388034/diff/5003/chrome/browser/resources/uber/uber.js File chrome/browser/resources/uber/uber.js (right): https://chromiumcodereview.appspot.com/10388034/diff/5003/chrome/browser/resources/uber/uber.js#newcode339 chrome/browser/resources/uber/uber.js:339: function setNavigationItemTabbing(enabled) { On 2012/05/08 23:51:31, Evan Stade wrote: ...
8 years, 7 months ago (2012-05-09 00:02:19 UTC) #5
dmazzoni
lgtm
8 years, 7 months ago (2012-05-09 05:40:41 UTC) #6
Evan Stade
lgtm
8 years, 7 months ago (2012-05-09 22:32:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/10388034/8002
8 years, 7 months ago (2012-05-11 02:55:21 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 04:20:18 UTC) #9 
Change committed as 136502

Powered by Google App Engine
This is Rietveld 408576698