Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10388005: Allow developers to try out dart2js in their web apps. (Closed)

Created:
8 years, 7 months ago by kasperl
Modified:
8 years, 7 months ago
Reviewers:
vsm, asandholm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow developers to try out dart2js in their web apps. We look for a dart-compiler attribute on the script tag and if it is set to dart2js we use the dart2js generated file. R=sandholm@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7418

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use data-compiler attribute. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M client/dart.js View 1 1 chunk +31 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kasperl
8 years, 7 months ago (2012-05-07 12:50:01 UTC) #1
kasperl
Adding Vijay as a reviewer. This is kinda hacky but it gives people a quick ...
8 years, 7 months ago (2012-05-07 12:52:02 UTC) #2
asandholm
LGTM https://chromiumcodereview.appspot.com/10388005/diff/1/client/dart.js File client/dart.js (right): https://chromiumcodereview.appspot.com/10388005/diff/1/client/dart.js#newcode22 client/dart.js:22: var compiler = "frog"; You could consider using ...
8 years, 7 months ago (2012-05-07 13:13:00 UTC) #3
vsm
My first thought would be to add this as a data attribute to the dart.js ...
8 years, 7 months ago (2012-05-07 14:14:28 UTC) #4
kasperl
On 2012/05/07 14:14:28, vsm wrote: > My first thought would be to add this as ...
8 years, 7 months ago (2012-05-07 14:17:39 UTC) #5
kasperl
PTAL.
8 years, 7 months ago (2012-05-08 13:12:15 UTC) #6
vsm
8 years, 7 months ago (2012-05-08 14:47:45 UTC) #7
lgtm!

Powered by Google App Engine
This is Rietveld 408576698