Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 10387234: printing: Remove views include from print_dialog_cloud.cc. (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

printing: Remove views include from print_dialog_cloud.cc. BUG=125846 R=ben@chromium.org TBR=abodenha@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 7 months ago (2012-05-22 16:01:47 UTC) #1
Ben Goodger (Google)
8 years, 7 months ago (2012-05-22 16:12:13 UTC) #2
LGTM

On Tue, May 22, 2012 at 9:01 AM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> printing: Remove views include from print_dialog_cloud.cc.
>
> BUG=125846
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10387234/<http://codereview.chromium.org/103...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/printing/print_**dialog_cloud.cc
>
>
> Index: chrome/browser/printing/print_**dialog_cloud.cc
> diff --git a/chrome/browser/printing/**print_dialog_cloud.cc
> b/chrome/browser/printing/**print_dialog_cloud.cc
> index ad0e57471b04406dee643186ecf474**d1ca5cab7a..**
> fc4aa38706e582b1827db10184e78d**87918ab41d 100644
> --- a/chrome/browser/printing/**print_dialog_cloud.cc
> +++ b/chrome/browser/printing/**print_dialog_cloud.cc
> @@ -20,8 +20,8 @@
>  #include "chrome/browser/printing/**cloud_print/cloud_print_url.h"
>  #include "chrome/browser/profiles/**profile.h"
>  #include "chrome/browser/profiles/**profile_manager.h"
> -#include "chrome/browser/ui/browser_**dialogs.h"
>  #include "chrome/browser/ui/browser.h"
> +#include "chrome/browser/ui/browser_**dialogs.h"
>  #include "chrome/browser/ui/browser_**finder.h"
>  #include "chrome/browser/ui/browser_**list.h"
>  #include "chrome/browser/ui/browser_**window.h"
> @@ -40,23 +40,14 @@
>  #include "content/public/browser/web_**contents.h"
>  #include "content/public/browser/web_**contents_view.h"
>  #include "content/public/browser/web_**ui.h"
> +#include "grit/generated_resources.h"
>  #include "ui/base/l10n/l10n_util.h"
> +#include "webkit/glue/webpreferences.h"
>
>  #if defined(OS_WIN)
>  #include "ui/base/win/foreground_**helper.h"
>  #endif
>
> -#include "webkit/glue/webpreferences.h"
> -
> -#include "grit/generated_resources.h"
> -
> -#if defined(USE_AURA)
> -#include "chrome/browser/ui/browser_**window.h"
> -#include "chrome/browser/ui/views/web_**dialog_view.h"
> -#include "ui/aura/root_window.h"
> -#include "ui/views/widget/widget.h"
> -#endif
> -
>  // This module implements the UI support in Chrome for cloud printing.
>  // This means hosting a dialog containing HTML/JavaScript and using
>  // the published cloud print user interface integration APIs to get
>
>
>

Powered by Google App Engine
This is Rietveld 408576698