Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 10387233: browser: Remove event_utils.h from DEPS. (Closed)

Created:
8 years, 7 months ago by tfarina
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

browser: Remove event_utils.h from DEPS. Now that r138256 is in, we can remove it since nobody outside chrome/browser/ui/views/ includes it. BUG=125846 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 7 months ago (2012-05-22 15:39:35 UTC) #1
Ben Goodger (Google)
8 years, 7 months ago (2012-05-22 16:00:24 UTC) #2
LGTM

On Tue, May 22, 2012 at 8:39 AM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> browser: Remove event_utils.h from DEPS.
>
> Now that r138256 is in, we can remove it since nobody outside
> chrome/browser/ui/views/ includes it.
>
> BUG=125846
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10387233/<http://codereview.chromium.org/103...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/DEPS
>
>
> Index: chrome/browser/DEPS
> diff --git a/chrome/browser/DEPS b/chrome/browser/DEPS
> index 18cfb9007107da23eb8c8451b7f720**da1ce80f9b..**
> eee85c0dead26c8106b9514a1b5156**383f758922 100644
> --- a/chrome/browser/DEPS
> +++ b/chrome/browser/DEPS
> @@ -58,7 +58,6 @@ include_rules = [
>   "+chrome/browser/ui/views/**browser_actions_container.h",
>   "+chrome/browser/ui/views/**chrome_views_delegate.h",
>   "+chrome/browser/ui/views/**constrained_window_views.h",
> -  "+chrome/browser/ui/views/**event_utils.h",
>   "+chrome/browser/ui/views/**extensions/extension_popup.h",
>   "+chrome/browser/ui/views/**extensions/extension_view.h",
>   "+chrome/browser/ui/views/**frame/browser_view.h",
>
>
>

Powered by Google App Engine
This is Rietveld 408576698