tools/testing/dart/test_progress.dart - Issue 10387232: Remove string concatenation with + from all Dart files in tools directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_progress.dart

Issue 10387232: Remove string concatenation with + from all Dart files in tools directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_progress.dart

diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart

index 975f49b7b031920686c2c93a33deac609f8c51b3..758d82e382ae2e69ac696e691fcc41ed7b50d694 100644

--- a/tools/testing/dart/test_progress.dart

+++ b/tools/testing/dart/test_progress.dart

@@ -252,7 +252,7 @@ class CompactProgressIndicator extends CompactIndicator {

var failedPadded = _pad(_failedTests.toString(), 5);

Duration d = (new Date.now()).difference(_startTime);

var progressLine =

- '\r[${_timeString(d)} | $progressPadded% | ' +

+ '\r[${_timeString(d)} | $progressPadded% | '

'+$passedPadded | -$failedPadded]';

stdout.write(progressLine.charCodes());

}

« no previous file with comments | « tools/testing/dart/multitest.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »