Issue 10387231: ClearNonLiveTransitions indepedent of ContentArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10387231: ClearNonLiveTransitions indepedent of ContentArray (Closed)

Created:
8 years, 7 months ago by Toon Verwaest

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ClearNonLiveTransitions indepedent of ContentArray Committed: https://code.google.com/p/v8/source/detail?r=11693

Patch Set 1 : rebase #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -10 lines)			Patch
M	src/objects.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	3 chunks	+7 lines, -10 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+13 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 6 months ago (2012-06-01 09:00:33 UTC) #2

LGTM (just one small nit).

https://chromiumcodereview.appspot.com/10387231/diff/6001/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/10387231/diff/6001/src/objects-inl.h#n...
src/objects-inl.h:1948: ASSERT(!HEAP->InNewSpace(heap->null_value()));
That assertion is already in FixedArray::set_null_unchecked, no need to
duplicate it here.

Expand Messages | Collapse Messages