Issue 10387228: chrome_shared.css -> chrome_shared2.css : proxy_settings.html - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(10)

My Issues | Starred Open | Closed | All

Issue 10387228: chrome_shared.css -> chrome_shared2.css : proxy_settings.html (Closed)

Created:
8 years, 7 months ago by Evan Stade

Modified:
4 years, 8 months ago

Reviewers:
btzartzanis, kenbi17111999, xiyuan, seargentbay, chessdrugsrocknroll, clayton.ferguson.294, briankeiths.40

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome_shared.css -> chrome_shared2.css : proxy_settings.html BUG=103688 TEST=manual (chrome://proxy-settings) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138349

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/browser/resources/chromeos/proxy_settings.html	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

briankeiths.40_gmail.com

.css : proxy_settings.html BUG=103688 > > On MondU Reviewers: xiyuan, Description: > chrome_shared.css -> chrome_shared2ay, ...

6 years, 1 month ago (2014-10-28 11:12:04 UTC) #3

seargentbay_gmail.com

how to delete school lan On Monday, May 21, 2012 at 11:19:51 PM UTC-4, Evan ...

5 years, 8 months ago (2015-04-06 14:17:17 UTC) #4

Message was sent while issue was closed.

how to delete school lan


On Monday, May 21, 2012 at 11:19:51 PM UTC-4, Evan Stade wrote:
>
> Reviewers: xiyuan, 
>
> Description: 
> chrome_shared.css -> chrome_shared2.css : proxy_settings.html 
>
> BUG=103688 
> TEST=manual (chrome://proxy-settings) 
>
>
> Please review this at https://chromiumcodereview.appspot.com/10387228/ 
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src 
>
> Affected files: 
>    M chrome/browser/resources/chromeos/proxy_settings.html 
>
>
> Index: chrome/browser/resources/chromeos/proxy_settings.html 
> diff --git a/chrome/browser/resources/chromeos/proxy_settings.html   
> b/chrome/browser/resources/chromeos/proxy_settings.html 
> index   
>
0884dbd2ced8c18a49ca56ff3c9bcd0751d5e0ba..485b2eaf6fbe8b46e365436944232af91d7abd70

>   
> 100644 
> --- a/chrome/browser/resources/chromeos/proxy_settings.html 
> +++ b/chrome/browser/resources/chromeos/proxy_settings.html 
> @@ -1,7 +1,7 @@ 
>   <!DOCTYPE HTML> 
>   <html i18n-values="dir:textdirection"> 
>   <head> 
> -<link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> 
> +<link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css"> 
>   <link rel="stylesheet" href="chrome://resources/css/list.css"> 
>   <link rel="stylesheet" href="chrome://resources/css/widgets.css"> 
>
> @@ -31,9 +31,7 @@ 
>   <script src="proxy_settings.js"></script> 
>   </head> 
>
> -<!-- We do not override the fontSize because it is defined in 
> -     internet_options_page.css. --> 
> -<body i18n-values=".style.fontFamily:fontfamily"> 
> +<body 
> i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 
>   <include src="../options2/chromeos/internet_detail.html"> 
>   </body> 
>   </html> 
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

kenbi17111999_gmail.com

Vào 10:19:51 UTC + 7 Thứ Ba, ngày 22 tháng 5 năm 2012, Evan Stade ...

5 years, 7 months ago (2015-04-28 10:27:18 UTC) #5

Message was sent while issue was closed.


Vào 10:19:51 UTC + 7 Thứ Ba, ngày 22 tháng 5 năm 2012, Evan Stade have viết:
>
> Nhận xét: Xiyuan, Mô tả: chrome_shared.css -> chrome_shared2.css: 
> proxy_settings.html BUG = 103.688 TEST = tay (chrome: // proxy-cài đặt) Vui 
> lòng xem lại này tại https: // chromiumcodereview. 
> <https://chromiumcodereview.appspot.com/10387228/>appspot.com/10387228/ 
> <https://chromiumcodereview.appspot.com/10387228/> SVN Base: svn: //
svn.chromium.org/chrome/ 
> <http://svn.chromium.org/chrome/trunk/src>trunk / src 
> <http://svn.chromium.org/chrome/trunk/src> file bị ảnh hưởng:    M chrome 
> / browser / tài nguyên / chromeos / proxy_settings.html Index: chrome / 
> browser / tài nguyên / chromeos / proxy_settings.html diff --git a / 
> chrome / browser / tài nguyên / chromeos / proxy_settings.html +++ b / 
> chrome / browser / tài nguyên / chromeos / proxy_settings.html @@-1,7 
> +1,7@@   <! DOCTYPE HTML>   <html i18n- giá trị = "dir: textdirection ">   
> <head> - <link rel = "stylesheet" href = "chrome: // nguồn / css /
chrome_shared.css 
> "> + <link rel = "stylesheet" href = "chrome: // nguồn lực / css /
chrome_shared2.css 
> ">   <link rel = "stylesheet" href = "chrome: // nguồn / css / list.css 
> ">   <link rel = "stylesheet" href = "chrome: // nguồn / css / widgets.css 
> "> @@-31,9 +31,7@@   <script src = "proxy_settings.js"> </ script>   </ 
> head> - <! - Chúng tôi không ghi đè các fontSize vì nó được định nghĩa 
> trong - internet_options_page.css. -> - <body i18n-values = ".. Phong 
> cách : fontFamily fontFamily "> ".. phong cách + <body i18n-values = . 
> fontFamily: fontFamily; .style fontSize: fontsize ">   <bao gồm src = 
> "../ options2 / chromeos / internet_detail.html ">   </ body>   </ html> 
>
>
>
>
>
>
>
>
> <https://chromiumcodereview.appspot.com/10387228/> 
>
> <http://svn.chromium.org/chrome/trunk/src> 
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

chessdrugsrocknroll_gmail.com

On Monday, May 21, 2012 at 11:19:51 PM UTC-4, Evan Stade wrote: > > Reviewers: ...

4 years, 10 months ago (2016-02-14 00:52:52 UTC) #6

Message was sent while issue was closed.


On Monday, May 21, 2012 at 11:19:51 PM UTC-4, Evan Stade wrote:
>
> Reviewers: xiyuan, 
>
> Description: 
> chrome_shared.css -> chrome_shared2.css : proxy_settings.html 
>
> BUG=103688 
> TEST=manual (chrome://proxy-settings) 
>
>
> Please review this at https://chromiumcodereview.appspot.com/10387228/ 
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src 
>
> Affected files: 
>    M chrome/browser/resources/chromeos/proxy_settings.html 
>
>
> Index: chrome/browser/resources/chromeos/proxy_settings.html 
> diff --git a/chrome/browser/resources/chromeos/proxy_settings.html   
> b/chrome/browser/resources/chromeos/proxy_settings.html 
> index   
>
0884dbd2ced8c18a49ca56ff3c9bcd0751d5e0ba..485b2eaf6fbe8b46e365436944232af91d7abd70

>   
> 100644 
> --- a/chrome/browser/resources/chromeos/proxy_settings.html 
> +++ b/chrome/browser/resources/chromeos/proxy_settings.html 
> @@ -1,7 +1,7 @@ 
>   <!DOCTYPE HTML> 
>   <html i18n-values="dir:textdirection"> 
>   <head> 
> -<link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> 
> +<link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css"> 
>   <link rel="stylesheet" href="chrome://resources/css/list.css"> 
>   <link rel="stylesheet" href="chrome://resources/css/widgets.css"> 
>
> @@ -31,9 +31,7 @@ 
>   <script src="proxy_settings.js"></script> 
>   </head> 
>
> -<!-- We do not override the fontSize because it is defined in 
> -     internet_options_page.css. --> 
> -<body i18n-values=".style.fontFamily:fontfamily"> 
> +<body 
> i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 
>   <include src="../options2/chromeos/internet_detail.html"> 
>   </body> 
>   </html> 
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

btzartzanis_yahoo.gr

*HOW TO DELETE AG* *ARIO NINJA!* Τη Τρίτη, 22 Μαΐου 2012 - 6:19:51 π.μ. UTC+3, ...

4 years, 9 months ago (2016-02-27 09:39:21 UTC) #7

Message was sent while issue was closed.

*HOW TO DELETE AG*
*ARIO NINJA!*



Τη Τρίτη, 22 Μαΐου 2012 - 6:19:51 π.μ. UTC+3, ο χρήστης Evan Stade έγραψε:
>
> Reviewers: xiyuan, 
>
> Description: 
> chrome_shared.css -> chrome_shared2.css : proxy_settings.html 
>
> BUG=103688 
> TEST=manual (chrome://proxy-settings) 
>
>
> Please review this at https://chromiumcodereview.appspot.com/10387228/ 
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src 
>
> Affected files: 
>    M chrome/browser/resources/chromeos/proxy_settings.html 
>
>
> Index: chrome/browser/resources/chromeos/proxy_settings.html 
> diff --git a/chrome/browser/resources/chromeos/proxy_settings.html   
> b/chrome/browser/resources/chromeos/proxy_settings.html 
> index   
>
0884dbd2ced8c18a49ca56ff3c9bcd0751d5e0ba..485b2eaf6fbe8b46e365436944232af91d7abd70

>   
> 100644 
> --- a/chrome/browser/resources/chromeos/proxy_settings.html 
> +++ b/chrome/browser/resources/chromeos/proxy_settings.html 
> @@ -1,7 +1,7 @@ 
>   <!DOCTYPE HTML> 
>   <html i18n-values="dir:textdirection"> 
>   <head> 
> -<link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> 
> +<link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css"> 
>   <link rel="stylesheet" href="chrome://resources/css/list.css"> 
>   <link rel="stylesheet" href="chrome://resources/css/widgets.css"> 
>
> @@ -31,9 +31,7 @@ 
>   <script src="proxy_settings.js"></script> 
>   </head> 
>
> -<!-- We do not override the fontSize because it is defined in 
> -     internet_options_page.css. --> 
> -<body i18n-values=".style.fontFamily:fontfamily"> 
> +<body 
> i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 
>   <include src="../options2/chromeos/internet_detail.html"> 
>   </body> 
>   </html> 
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

clayton.ferguson.294_k12.friscoisd.org

4 years, 8 months ago (2016-04-04 17:12:47 UTC) #8

Message was sent while issue was closed.

Lets have a meeting tomorrow 
       -marcus please lets have it  

On Monday, May 21, 2012 at 10:19:51 PM UTC-5, Evan Stade wrote:
>
> Reviewers: xiyuan, 
>
> Description: 
> chrome_shared.css -> chrome_shared2.css : proxy_settings.html 
>
> BUG=103688 
> TEST=manual (chrome://proxy-settings) 
>
>
> Please review this at https://chromiumcodereview.appspot.com/10387228/ 
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src 
>
> Affected files: 
>    M chrome/browser/resources/chromeos/proxy_settings.html 
>
>
> Index: chrome/browser/resources/chromeos/proxy_settings.html 
> diff --git a/chrome/browser/resources/chromeos/proxy_settings.html   
> b/chrome/browser/resources/chromeos/proxy_settings.html 
> index   
>
0884dbd2ced8c18a49ca56ff3c9bcd0751d5e0ba..485b2eaf6fbe8b46e365436944232af91d7abd70

>   
> 100644 
> --- a/chrome/browser/resources/chromeos/proxy_settings.html 
> +++ b/chrome/browser/resources/chromeos/proxy_settings.html 
> @@ -1,7 +1,7 @@ 
>   <!DOCTYPE HTML> 
>   <html i18n-values="dir:textdirection"> 
>   <head> 
> -<link rel="stylesheet" href="chrome://resources/css/chrome_shared.css"> 
> +<link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css"> 
>   <link rel="stylesheet" href="chrome://resources/css/list.css"> 
>   <link rel="stylesheet" href="chrome://resources/css/widgets.css"> 
>
> @@ -31,9 +31,7 @@ 
>   <script src="proxy_settings.js"></script> 
>   </head> 
>
> -<!-- We do not override the fontSize because it is defined in 
> -     internet_options_page.css. --> 
> -<body i18n-values=".style.fontFamily:fontfamily"> 
> +<body 
> i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 
>   <include src="../options2/chromeos/internet_detail.html"> 
>   </body> 
>   </html> 
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698