Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 10387226: [chromoting] Fix sticky c key with cmd on mac using usb keycode (Closed)

Created:
8 years, 7 months ago by Alpha Left Google
Modified:
8 years, 7 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[chromoting] Fix sticky c key with cmd on mac using usb keycode Switch to use USB keycode for the fix for sticky keys on Mac. BUG=101937 TEST=Build on Mac and run chromoting and press cmd+c Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138205

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -230 lines) Patch
M remoting/client/plugin/mac_key_event_processor.h View 3 chunks +3 lines, -13 lines 0 comments Download
M remoting/client/plugin/mac_key_event_processor.cc View 1 3 chunks +34 lines, -23 lines 0 comments Download
M remoting/client/plugin/mac_key_event_processor_unittest.cc View 2 chunks +106 lines, -194 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alpha Left Google
8 years, 7 months ago (2012-05-22 00:13:28 UTC) #1
Wez
lgtm http://codereview.chromium.org/10387226/diff/1/remoting/client/plugin/mac_key_event_processor.cc File remoting/client/plugin/mac_key_event_processor.cc (right): http://codereview.chromium.org/10387226/diff/1/remoting/client/plugin/mac_key_event_processor.cc#newcode32 remoting/client/plugin/mac_key_event_processor.cc:32: void MacKeyEventProcessor::InjectKeyEvent(const protocol::KeyEvent& event) { nit: DCHECK(event.has_usb_keycode()); http://codereview.chromium.org/10387226/diff/1/remoting/client/plugin/mac_key_event_processor.cc#newcode33 ...
8 years, 7 months ago (2012-05-22 00:17:08 UTC) #2
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 01:17:52 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698