Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10387224: Rename ExtensionCommand* to Command* within the extension namespace. (Closed)

Created:
8 years, 7 months ago by Finnur
Modified:
8 years, 7 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Rename ExtensionCommand* to Command* within the extensions namespace. BUG=None TEST=None, no effective change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138341

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -1269 lines) Patch
A + chrome/browser/extensions/api/commands/command_service.h View 4 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/api/commands/command_service.cc View 10 chunks +13 lines, -16 lines 0 comments Download
A + chrome/browser/extensions/api/commands/command_service_factory.h View 1 chunk +12 lines, -12 lines 0 comments Download
A + chrome/browser/extensions/api/commands/command_service_factory.cc View 1 chunk +13 lines, -13 lines 0 comments Download
D chrome/browser/extensions/api/commands/extension_command_service.h View 1 2 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/extensions/api/commands/extension_command_service.cc View 1 2 1 chunk +0 lines, -243 lines 0 comments Download
D chrome/browser/extensions/api/commands/extension_command_service_factory.h View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/extensions/api/commands/extension_command_service_factory.cc View 1 2 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/browser_actions_container.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/command_handler.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + chrome/browser/ui/webui/extensions/command_handler.cc View 6 chunks +15 lines, -18 lines 0 comments Download
D chrome/browser/ui/webui/extensions/extension_commands_handler.h View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/ui/webui/extensions/extension_commands_handler.cc View 1 2 1 chunk +0 lines, -117 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/command.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/extensions/command.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/command_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/extension_commands.h View 1 2 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/common/extensions/extension_commands.cc View 1 2 1 chunk +0 lines, -238 lines 0 comments Download
D chrome/common/extensions/extension_commands_unittest.cc View 1 2 1 chunk +0 lines, -195 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
Simple rename, as requested be Aaron. Shouldn't be any effective code change. Ben, can you ...
8 years, 7 months ago (2012-05-22 18:13:36 UTC) #1
Ben Goodger (Google)
rubber stamp LGTM
8 years, 7 months ago (2012-05-22 19:07:19 UTC) #2
Aaron Boodman
8 years, 7 months ago (2012-05-22 19:16:47 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698