Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 10387211: Merged r11533, r11570 into 3.10 branch. (Closed)

Created:
8 years, 7 months ago by danno
Modified:
8 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merged r11533, r11570 into 3.10 branch. Properly set ElementsKind of empty FAST_DOUBLE_ELEMENTS arrays when transitioning. Always transition empty FAST_DOUBLE_ARRAYs on push. BUG=chromium:117409, chromium:128018 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -14 lines) Patch
M src/builtins.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-117409.js View 1 chunk +52 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-128018.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
8 years, 7 months ago (2012-05-21 10:03:56 UTC) #1
Michael Starzinger
8 years, 7 months ago (2012-05-21 11:07:29 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698