Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: webkit/media/webmediaplayer_impl.cc

Issue 10387202: Fix reporting of Media.AcceleratedCompositingActive when false. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/webmediaplayer_impl.cc
diff --git a/webkit/media/webmediaplayer_impl.cc b/webkit/media/webmediaplayer_impl.cc
index f45cae406be7a3bb8bbbe8bcec8c851684232598..2fabfd68e45ca9cc1a03c2eb19a60caa3bf22a0f 100644
--- a/webkit/media/webmediaplayer_impl.cc
+++ b/webkit/media/webmediaplayer_impl.cc
@@ -501,6 +501,12 @@ void WebMediaPlayerImpl::paint(WebCanvas* canvas,
DCHECK_EQ(main_loop_, MessageLoop::current());
DCHECK(proxy_);
+ if (!accelerated_compositing_reported_) {
+ accelerated_compositing_reported_ = true;
+ DCHECK_EQ(frame_->view()->isAcceleratedCompositingActive(), false);
+ UMA_HISTOGRAM_BOOLEAN("Media.AcceleratedCompositingActive", false);
+ }
+
proxy_->Paint(canvas, rect, alpha);
}
@@ -563,8 +569,8 @@ void WebMediaPlayerImpl::putCurrentFrame(
WebKit::WebVideoFrame* web_video_frame) {
if (!accelerated_compositing_reported_) {
accelerated_compositing_reported_ = true;
- UMA_HISTOGRAM_BOOLEAN("Media.AcceleratedCompositingActive",
- frame_->view()->isAcceleratedCompositingActive());
+ DCHECK_EQ(frame_->view()->isAcceleratedCompositingActive(), true);
+ UMA_HISTOGRAM_BOOLEAN("Media.AcceleratedCompositingActive", true);
}
if (web_video_frame) {
scoped_refptr<media::VideoFrame> video_frame(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698