Fix reporting of Media.AcceleratedCompositingActive when false.

Fix reporting of Media.AcceleratedCompositingActive when false.

This broke sometime during the m19 branch, seemingly after 19.0.1081.2 but
before 19.0.1084.46.

TEST=inspect chrome://histograms/Media.Acc after playing <video> with and without accelerated compositing.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138029

[Ami GONE FROM CHROMIUM, 2012-05-19 01:25:32]

D'oh!

https://chromiumcodereview.appspot.com/10387202/diff/1/webkit/media/webmediap...
File webkit/media/webmediaplayer_impl.cc (right):

https://chromiumcodereview.appspot.com/10387202/diff/1/webkit/media/webmediap...
webkit/media/webmediaplayer_impl.cc:507:
frame_->view()->isAcceleratedCompositingActive());
Could also just use false here (and true at the other reporting site) instead of
frame_->view()->isAcceleratedCompositingActive() but figured it was better this
way.  Could be convinced.

[scherkus (not reviewing), 2012-05-19 02:09:31]

LGTM w/ suggestion

https://chromiumcodereview.appspot.com/10387202/diff/1/webkit/media/webmediap...
File webkit/media/webmediaplayer_impl.cc (right):

https://chromiumcodereview.appspot.com/10387202/diff/1/webkit/media/webmediap...
webkit/media/webmediaplayer_impl.cc:507:
frame_->view()->isAcceleratedCompositingActive());
On 2012/05/19 01:25:32, Ami Fischman wrote:
> Could also just use false here (and true at the other reporting site) instead
of
> frame_->view()->isAcceleratedCompositingActive() but figured it was better
this
> way.  Could be convinced.

report false + comment w/ DCHECK to be safe and catch breakage should things
change?

[Ami GONE FROM CHROMIUM, 2012-05-19 02:48:24]

https://chromiumcodereview.appspot.com/10387202/diff/1/webkit/media/webmediap...
File webkit/media/webmediaplayer_impl.cc (right):

https://chromiumcodereview.appspot.com/10387202/diff/1/webkit/media/webmediap...
webkit/media/webmediaplayer_impl.cc:507:
frame_->view()->isAcceleratedCompositingActive());
On 2012/05/19 02:09:31, scherkus wrote:
> On 2012/05/19 01:25:32, Ami Fischman wrote:
> > Could also just use false here (and true at the other reporting site)
instead
> of
> > frame_->view()->isAcceleratedCompositingActive() but figured it was better
> this
> > way.  Could be convinced.
> 
> report false + comment w/ DCHECK to be safe and catch breakage should things
> change?

Done.

[commit-bot: I haz the power, 2012-05-19 02:48:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/10387202/2002

[commit-bot: I haz the power, 2012-05-19 04:33:22]

Try job failure for 10387202-2002 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, net_unittests, unit_tests,
base_unittests, media_unittests, content_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-05-19 04:37:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fischman@chromium.org/10387202/2002

[commit-bot: I haz the power, 2012-05-19 06:14:35]

Change committed as 138029

[jamesr, 2012-05-21 19:12:09]

This appears to make
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html fail an ASSERT() in
debug:

crash log for DumpRenderTree (pid 14181):
STDOUT: <empty>
STDERR: [14181:14181:5089393851401:FATAL:webmediaplayer_impl.cc(506)] Check
failed: frame_->view()->isAcceleratedCompositingActive() == false (1 vs. 0)
STDERR: Backtrace:
STDERR: 	base::debug::StackTrace::StackTrace() [0x873dfa]
STDERR: 	logging::LogMessage::~LogMessage() [0x80758b]
STDERR: 	webkit_media::WebMediaPlayerImpl::paint() [0x1f8cdb9]
STDERR: 	WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext()
[0x53ab14]
STDERR: 	WebCore::MediaPlayer::paintCurrentFrameInContext() [0x1154cf0]
STDERR: 	WebCore::HTMLVideoElement::paintCurrentFrameInContext() [0x10a66bd]
STDERR: 	WebCore::WebGLRenderingContext::videoFrameToImage() [0x103323d]
STDERR: 	WebCore::WebGLRenderingContext::texImage2D() [0x10332c2]
STDERR: 	WebCore::WebGLRenderingContextV8Internal::texImage2D5Callback()
[0x1d22bb1]
STDERR: 	WebCore::WebGLRenderingContextV8Internal::texImage2DCallback()
[0x1d22f01]
STDERR: 	v8::internal::HandleApiCallHelper<>() [0xb441d4]
STDERR: 	v8::internal::Builtin_Impl_HandleApiCall() [0xb3f148]
STDERR: 	v8::internal::Builtin_HandleApiCall() [0xb3f119]
STDERR: 	0x52d96f0618e
STDERR:

[jamesr, 2012-05-21 19:12:21]

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...

[Peter Kasting, 2012-05-21 19:43:14]

I filed http://crbug.com/129030 for this.