Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: webkit/media/cache_util_unittest.cc

Issue 10387200: Suppress pause-and-buffer behavior when the HTTP response won't satisfy future requests via cache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: %zu is win-unfriendly; use %PRIuS instead. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/media/cache_util.cc ('k') | webkit/media/webkit_media.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/cache_util_unittest.cc
diff --git a/webkit/media/cache_util_unittest.cc b/webkit/media/cache_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..808084aa03982b21d32dadf6171e5d4b2680c492
--- /dev/null
+++ b/webkit/media/cache_util_unittest.cc
@@ -0,0 +1,97 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/media/cache_util.h"
+
+#include <string>
+
+#include "base/format_macros.h"
+#include "base/stringprintf.h"
+#include "base/string_number_conversions.h"
+#include "base/string_util.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLResponse.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using WebKit::WebString;
+using WebKit::WebURLResponse;
+
+namespace webkit_media {
+
+// Inputs & expected output for GetReasonsForUncacheability.
+struct GRFUTestCase {
+ WebURLResponse::HTTPVersion version;
+ int status_code;
+ const char* headers;
+ uint32 expected_reasons;
+};
+
+// Create a new WebURLResponse object.
+static WebURLResponse CreateResponse(const GRFUTestCase& test) {
+ WebURLResponse response;
+ response.initialize();
+ response.setHTTPVersion(test.version);
+ response.setHTTPStatusCode(test.status_code);
+ std::vector<std::string> lines;
+ Tokenize(test.headers, "\n", &lines);
+ for (size_t i = 0; i < lines.size(); ++i) {
+ size_t colon = lines[i].find(": ");
+ response.addHTTPHeaderField(
+ WebString::fromUTF8(lines[i].substr(0, colon)),
+ WebString::fromUTF8(lines[i].substr(colon + 2)));
+ }
+ return response;
+}
+
+TEST(CacheUtilTest, GetReasonsForUncacheability) {
+ enum { kNoReasons = 0 };
+
+ const GRFUTestCase tests[] = {
+ {
+ WebURLResponse::HTTP_1_1, 206, "ETag: 'fooblort'", kNoReasons
+ },
+ {
+ WebURLResponse::HTTP_1_1, 206, "", kNoStrongValidatorOnPartialResponse
+ },
+ {
+ WebURLResponse::HTTP_1_0, 206, "",
+ kPre11PartialResponse | kNoStrongValidatorOnPartialResponse
+ },
+ {
+ WebURLResponse::HTTP_1_1, 200, "cache-control: max-Age=42", kShortMaxAge
+ },
+ {
+ WebURLResponse::HTTP_1_1, 200, "cache-control: max-Age=4200", kNoReasons
+ },
+ {
+ WebURLResponse::HTTP_1_1, 200,
+ "Date: Tue, 22 May 2012 23:46:08 GMT\n"
+ "Expires: Tue, 22 May 2012 23:56:08 GMT", kExpiresTooSoon
+ },
+ {
+ WebURLResponse::HTTP_1_1, 200, "cache-control: must-revalidate",
+ kHasMustRevalidate
+ },
+ {
+ WebURLResponse::HTTP_1_1, 200, "cache-control: no-cache", kNoCache
+ },
+ {
+ WebURLResponse::HTTP_1_1, 200, "cache-control: no-store", kNoStore
+ },
+ {
+ WebURLResponse::HTTP_1_1, 200,
+ "cache-control: no-cache\ncache-control: no-store", kNoCache | kNoStore
+ },
+ };
+ for (size_t i = 0; i < arraysize(tests); ++i) {
+ SCOPED_TRACE(StringPrintf("case: %" PRIuS
+ ", version: %d, code: %d, headers: %s",
+ i, tests[i].version, tests[i].status_code,
+ tests[i].headers));
+ EXPECT_EQ(GetReasonsForUncacheability(CreateResponse(tests[i])),
+ tests[i].expected_reasons);
+ }
+}
+
+} // namespace webkit_media
« no previous file with comments | « webkit/media/cache_util.cc ('k') | webkit/media/webkit_media.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698