Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: webkit/media/buffered_data_source.cc

Issue 10387200: Suppress pause-and-buffer behavior when the HTTP response won't satisfy future requests via cache. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: %zu is win-unfriendly; use %PRIuS instead. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_util.cc ('k') | webkit/media/buffered_resource_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/buffered_data_source.cc
diff --git a/webkit/media/buffered_data_source.cc b/webkit/media/buffered_data_source.cc
index a7a01b2d2384a7209cbef99202207e5b0a646aa2..b285c9071b0b3325342e21f21a6f15a618e52835 100644
--- a/webkit/media/buffered_data_source.cc
+++ b/webkit/media/buffered_data_source.cc
@@ -280,9 +280,9 @@ void BufferedDataSource::SetPlaybackRateTask(float playback_rate) {
loader_->UpdateDeferStrategy(BufferedResourceLoader::kThresholdDefer);
} else if (media_has_played_ && playback_rate == 0) {
// If the playback has started (at which point the preload value is ignored)
- // and we're paused, then try to load as much as possible.
- // TODO(fischman): except, don't do this if we can prove that the media
- // cache is just throwing away the bits anyway. http://crbug.com/123074
+ // and we're paused, then try to load as much as possible (the loader will
+ // fall back to kThresholdDefer if it knows the current response won't be
+ // useful from the cache in the future).
loader_->UpdateDeferStrategy(BufferedResourceLoader::kNeverDefer);
} else {
// If media is currently playing or the page indicated preload=auto,
« no previous file with comments | « net/http/http_util.cc ('k') | webkit/media/buffered_resource_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698