Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Side by Side Diff: skia/skia_test_expectations.txt

Issue 10387188: Add skia_test_expectations file; see https://bugs.webkit.org/show_bug.cgi?id=86749 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Property Changes:
Added: svn:eol-style
+ LF
OLDNEW
(Empty)
1 // TEMPORARY overrides of
2 // src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt
3 // that are associated with changes to the Skia code.
4 //
5 // GUIDELINES:
6 // - This file should be empty most of the time.
7 // - Expectations should only be added TEMPORARILY, as a step towards
8 // rebaselining layout test results. If any one expectation remains in here
9 // for more than a week or two, then we are probably doing something wrong.
10 // - Expectations from this file should NOT be rolled into any other
11 // test_expectations file. If there is a test that we expect to fail
12 // indefinitely, then we should add that test to the roach motel that is
13 // src/third_party/WebKit/LayoutTests/platform/chromium/test_expectations.txt
14 // - Tests listed in this file should NOT be rebaselined by WebKit Gardeners,
15 // unless they have made arrangements with Skia developers.
16 //
17 // For more information, see https://bugs.webkit.org/show_bug.cgi?id=86749
18 // or email skia-dev@google.com .
19 //
20 // INSTRUCTIONS:
21 // If you are rolling Skia's DEPS within Chrome, and trybot results indicate
22 // that the DEPS roll would break some webkit layout_tests, please follow
23 // these steps:
24 //
25 // 1. Confirm that those layout_test failures are "reasonable"-- Are they
26 // actually improvements, not regressions? Or maybe they are very minor
27 // differences that go along with a performance improvement?
28 // If not, please fix Skia rather than rolling in the version that will
29 // regress the webkit layout_tests.
30 //
31 // 2. File a bug to yourself to track the rebaselining of results caused by
32 // your Skia DEPS roll.
33 //
34 // 3. Add one or more lines to this file, in the same syntax used in the main
35 // test_expectations file, to mark those tests as expected-to-fail.
36 // Add this file to your DEPS roll CL.
37 //
38 // 4. Run your DEPS roll CL through the trybots again, and confirm your CL does
39 // not cause any layout tests to fail. (If there are still failures as a
40 // result of your CL, you probably didn't add the test expectations correctly.)
41 //
42 // 5. Commit your DEPS roll CL, and keep an eye on the waterfall bots to make
43 // sure nothing goes red.
44 //
45 // 6. Make sure to rebaseline the layout tests as soon as possible! The longer
46 // we leave overrides in this file, the harder it will be to rebaseline those
47 // tests (because other rendering changes might creep in).
48 //
49 // START OVERRIDES HERE
50
51
52 // END OVERRIDES HERE (this line ensures that the file is newline-terminated)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698