Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 10387167: Revert 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer_browsertest.cc
===================================================================
--- chrome/browser/extensions/crx_installer_browsertest.cc (revision 137574)
+++ chrome/browser/extensions/crx_installer_browsertest.cc (working copy)
@@ -14,7 +14,6 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_file_util.h"
-#include "chrome/common/extensions/extension_switch_utils.h"
#include "chrome/test/base/ui_test_utils.h"
class SkBitmap;
@@ -68,10 +67,10 @@
return false;
scoped_ptr<WebstoreInstaller::Approval> approval(
- WebstoreInstaller::Approval::CreateWithNoInstallPrompt(
- browser()->profile(),
- id,
- scoped_ptr<base::DictionaryValue>(parsed_manifest)));
+ new WebstoreInstaller::Approval);
+ approval->extension_id = id;
+ approval->profile = browser()->profile();
+ approval->parsed_manifest.reset(parsed_manifest);
scoped_refptr<CrxInstaller> installer(
CrxInstaller::Create(service,
@@ -125,9 +124,6 @@
}
IN_PROC_BROWSER_TEST_F(ExtensionCrxInstallerTest, PackAndInstallExtension) {
- if (!extensions::switch_utils::IsOffStoreInstallEnabled())
- return;
-
const int kNumDownloadsExpected = 1;
const bool kExpectFileSelectDialog = false;
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698