chrome/browser/download/download_shelf_context_menu.cc - Issue 10387167: Revert 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_shelf_context_menu.cc

Issue 10387167: Revert 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/download_shelf_context_menu.cc

===================================================================

--- chrome/browser/download/download_shelf_context_menu.cc (revision 137574)

+++ chrome/browser/download/download_shelf_context_menu.cc (working copy)

@@ -11,7 +11,6 @@

#include "chrome/browser/safe_browsing/download_protection_service.h"

#include "chrome/browser/safe_browsing/safe_browsing_service.h"

#include "chrome/common/extensions/extension.h"

-#include "chrome/common/extensions/extension_switch_utils.h"

#include "content/public/browser/download_item.h"

#include "content/public/browser/download_manager.h"

#include "grit/generated_resources.h"

@@ -51,7 +50,7 @@

return download_item_->CanShowInFolder() &&

!download_item_->IsTemporary() &&

(!Extension::IsExtension(download_item_->GetTargetName()) ||

- extensions::switch_utils::IsOffStoreInstallEnabled());

+ download_crx_util::ShouldOpenExtensionDownload(*download_item_));

case ALWAYS_OPEN_TYPE:

// For temporary downloads, the target filename might be a temporary

// filename. Don't base an "Always open" decision based on it. Also

« no previous file with comments | « chrome/browser/download/download_crx_util.cc ('k') | chrome/browser/extensions/bundle_installer.cc » ('j') | no next file with comments »