Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5008)

Unified Diff: chrome/browser/extensions/extension_webstore_private_api.cc

Issue 10387167: Revert 137540 - Disable off-store extension installs by default. Also get rid of ExtensionService::… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_webstore_private_api.cc
===================================================================
--- chrome/browser/extensions/extension_webstore_private_api.cc (revision 137574)
+++ chrome/browser/extensions/extension_webstore_private_api.cc (working copy)
@@ -403,8 +403,10 @@
// the future we may also want to add time-based expiration, where a whitelist
// entry is only valid for some number of minutes.
scoped_ptr<WebstoreInstaller::Approval> approval(
- WebstoreInstaller::Approval::CreateWithNoInstallPrompt(
- profile(), id_, parsed_manifest_.Pass()));
+ new WebstoreInstaller::Approval);
+ approval->extension_id = id_;
+ approval->profile = profile();
+ approval->parsed_manifest.reset(parsed_manifest_.release());
approval->use_app_installed_bubble = use_app_installed_bubble_;
g_pending_approvals.Get().PushApproval(approval.Pass());
@@ -508,8 +510,11 @@
// extension. The whitelist entry gets cleared in
// CrxInstaller::ConfirmInstall.
scoped_ptr<WebstoreInstaller::Approval> approval(
- WebstoreInstaller::Approval::CreateWithNoInstallPrompt(
- profile(), id_, scoped_ptr<base::DictionaryValue>(parsed_manifest)));
+ new WebstoreInstaller::Approval);
+ approval->extension_id = id_;
+ approval->parsed_manifest.reset(parsed_manifest);
+ approval->profile = profile();
+ approval->use_app_installed_bubble = false;
approval->skip_post_install_ui = true;
scoped_refptr<WebstoreInstaller> installer = new WebstoreInstaller(
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/extensions/webstore_inline_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698