Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 10387162: Add additional stats for print preview. (Closed)

Created:
8 years, 7 months ago by Albert Bodenhamer
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add additional stats for print preview. Adds a new histogram that can be called from JS to record stats on the upcoming destination selector. BUG=128275 TEST=No user visible change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137620

Patch Set 1 #

Patch Set 2 : Add signin tracking #

Total comments: 1

Patch Set 3 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 9 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Albert Bodenhamer
I opted to constrain the UMA events we could trigger from JS. The downside is ...
8 years, 7 months ago (2012-05-16 22:07:12 UTC) #1
Scott Byer
http://codereview.chromium.org/10387162/diff/2001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): http://codereview.chromium.org/10387162/diff/2001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode745 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:745: ReportUserActionHistogram(PRINT_WITH_CLOUD_PRINT); Isn't this redundant with HandlePrintWithCloudPrint()'s reporting?
8 years, 7 months ago (2012-05-16 23:24:06 UTC) #2
Albert Bodenhamer
On 2012/05/16 23:24:06, Scott Byer wrote: > http://codereview.chromium.org/10387162/diff/2001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc > File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): > > http://codereview.chromium.org/10387162/diff/2001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode745 ...
8 years, 7 months ago (2012-05-16 23:41:45 UTC) #3
Scott Byer
lgtm
8 years, 7 months ago (2012-05-16 23:54:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10387162/3002
8 years, 7 months ago (2012-05-16 23:55:36 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 02:57:24 UTC) #6
Change committed as 137620

Powered by Google App Engine
This is Rietveld 408576698