Issue 10387158: Merge 136934 - Notify sync observers whenever preferred types change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10387158: Merge 136934 - Notify sync observers whenever preferred types change (Closed)

Created:
8 years, 7 months ago by Andrew T Wilson (Slow)

Modified:
8 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/1132/src/

Visibility:
Public.

More Reviews

Description

Merge 136934 - Notify sync observers whenever preferred types change Changed ProfileSyncService so any call to OnUserChoseDatatypes() will result in observers being notified even if configuration is aborted due to passphrase-required errors. Also updated sync config UI so the "invalid passphrase" error is generated even for blank passphrases. BUG=122734 TEST=Turn on explicit passphrase, setup sync, turn off passwords, click OK. Then go into settings and turn passwords on again, click OK, then cancel out of the dialog - wrench menu should have "passphrase error" badge. Review URL: https://chromiumcodereview.appspot.com/10382071 TBR=atwilson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137482

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -8 lines)			Patch
M	chrome/browser/sync/profile_sync_service.cc	View	5 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View	5 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	1 chunk	+18 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages