[Views, WebIntents] Hide suggestion label if none are available.

[Views, WebIntents] Hide suggestion label if none are available.

BUG=127996
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137589

[groby-ooo-7-16, 2012-05-15 23:22:17]

Please review. Screenshots on bug.

[Peter Kasting, 2012-05-16 22:09:27]

LGTM

https://chromiumcodereview.appspot.com/10387142/diff/1/chrome/browser/ui/view...
File chrome/browser/ui/views/web_intent_picker_views.cc (right):

https://chromiumcodereview.appspot.com/10387142/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/web_intent_picker_views.cc:954: if
(model->GetInstalledServiceCount() == 0) {
Nit: While here, shorter:

  suggestions_label_->SetText(l10n_util::GetStringUTF16(
      model->GetInstalledServiceCount() ?
      IDS_INTENT_PICKER_GET_MORE_SERVICES :
      IDS_INTENT_PICKER_GET_MORE_SERVICES_NONE_INSTALLED));

https://chromiumcodereview.appspot.com/10387142/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/web_intent_picker_views.cc:962: if
(model->GetSuggestedExtensionCount() == 0)
Nit: Simpler:

  suggestions_label_->SetVisible(model->GetSuggestedExtensionCount() > 0);

[groby-ooo-7-16, 2012-05-16 23:03:07]

https://chromiumcodereview.appspot.com/10387142/diff/1/chrome/browser/ui/view...
File chrome/browser/ui/views/web_intent_picker_views.cc (right):

https://chromiumcodereview.appspot.com/10387142/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/web_intent_picker_views.cc:954: if
(model->GetInstalledServiceCount() == 0) {
On 2012/05/16 22:09:27, Peter Kasting wrote:
> Nit: While here, shorter:
> 
>   suggestions_label_->SetText(l10n_util::GetStringUTF16(
>       model->GetInstalledServiceCount() ?
>       IDS_INTENT_PICKER_GET_MORE_SERVICES :
>       IDS_INTENT_PICKER_GET_MORE_SERVICES_NONE_INSTALLED));

Done.

https://chromiumcodereview.appspot.com/10387142/diff/1/chrome/browser/ui/view...
chrome/browser/ui/views/web_intent_picker_views.cc:962: if
(model->GetSuggestedExtensionCount() == 0)
On 2012/05/16 22:09:27, Peter Kasting wrote:
> Nit: Simpler:
> 
>   suggestions_label_->SetVisible(model->GetSuggestedExtensionCount() > 0);

Done.

[commit-bot: I haz the power, 2012-05-16 23:03:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10387142/5001

[commit-bot: I haz the power, 2012-05-17 00:53:12]

Change committed as 137589