[OSX, WebIntents] Display suggestions label, unless there are no suggestions.

Display suggestions label, unless there are no suggestions.

BUG=127996
TEST=WebIntentPickerSheetControllerTest.SuggestionView


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137709

[groby-ooo-7-16, 2012-05-15 22:47:56]

Sorry, forgot to say - screenshots on bug

[Nico, 2012-05-16 22:02:45]

1 questions about an if, the rest is fine

https://chromiumcodereview.appspot.com/10387141/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right):

https://chromiumcodereview.appspot.com/10387141/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:77: +
(void)configureTextFieldAsLabel:(NSTextField*)field {
nit: static methods can usually just be static toplevel functions

https://chromiumcodereview.appspot.com/10387141/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:393: if
(model->GetInstalledServiceCount()!=0) {
spaces around !=

https://chromiumcodereview.appspot.com/10387141/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:394: if
(model->GetInstalledServiceCount() == 0)
wait what? isn't that the negation of the previous condition? will this ever be
true?

[groby-ooo-7-16, 2012-05-16 23:27:02]

https://chromiumcodereview.appspot.com/10387141/diff/1/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right):

https://chromiumcodereview.appspot.com/10387141/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:77: +
(void)configureTextFieldAsLabel:(NSTextField*)field {
On 2012/05/16 22:02:45, Nico wrote:
> nit: static methods can usually just be static toplevel functions

Done.

https://chromiumcodereview.appspot.com/10387141/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:393: if
(model->GetInstalledServiceCount()!=0) {
On 2012/05/16 22:02:45, Nico wrote:
> spaces around !=

Done.

https://chromiumcodereview.appspot.com/10387141/diff/1/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:394: if
(model->GetInstalledServiceCount() == 0)
No, it won't. The first condition was wrong. Fixed.
On 2012/05/16 22:02:45, Nico wrote:
> wait what? isn't that the negation of the previous condition? will this ever
be
> true?

[Nico, 2012-05-16 23:33:05]

https://chromiumcodereview.appspot.com/10387141/diff/5001/chrome/browser/ui/c...
just says "old chunk mismatch" for me. can you upload again?

[groby-ooo-7-16, 2012-05-16 23:41:22]

Re-uploaded.

[Nico, 2012-05-16 23:55:25]

lgtm

https://chromiumcodereview.appspot.com/10387141/diff/4003/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right):

https://chromiumcodereview.appspot.com/10387141/diff/4003/chrome/browser/ui/c...
chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:388: if
(model->GetSuggestedExtensionCount() != 0) {
nit "> 0"

[commit-bot: I haz the power, 2012-05-17 17:38:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/10387141/13001

[commit-bot: I haz the power, 2012-05-17 19:35:34]

Change committed as 137709