Issue 10387129: [filemanager] In gallery, do not create a copy when renaming while editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10387129: [filemanager] In gallery, do not create a copy when renaming while editing. (Closed)

Created:
8 years, 7 months ago by dgozman

Modified:
8 years, 7 months ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

[filemanager] In gallery, do not create a copy when renaming while editing. BUG=126861 TEST=See bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137133

Patch Set 1 #

Total comments: 2

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View		2 chunks	+6 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

LGTM with a comment https://chromiumcodereview.appspot.com/10387129/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right): https://chromiumcodereview.appspot.com/10387129/diff/1/chrome/browser/resources/file_manager/js/image_editor/gallery.js#newcode545 chrome/browser/resources/file_manager/js/image_editor/gallery.js:545: //if (self.imageChanges_ > 0) { ...

8 years, 7 months ago (2012-05-15 15:05:12 UTC) #2

dgozman

8 years, 7 months ago (2012-05-15 15:10:32 UTC) #3

Thanks, committing.

https://chromiumcodereview.appspot.com/10387129/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/image_editor/gallery.js (right):

https://chromiumcodereview.appspot.com/10387129/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/image_editor/gallery.js:545: //if
(self.imageChanges_ > 0) {
On 2012/05/15 15:05:12, Vladislav Kaznacheev wrote:
> Code in comment

Done.

Expand Messages | Collapse Messages