Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 10387110: Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove stray comment Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/common/chrome_view_type.h ('K') | « chrome/renderer/extensions/extension_custom_bindings.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 934ad7a50463b22c8b8c717ebe9aae80efcf21e2..be904193bb5e6d874f3814eb316fbf5765aeffc2 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -702,7 +702,11 @@ class CONTENT_EXPORT WebContentsImpl
// (full-page plugins for now only) permissions.
int content_restrictions_;
- // Our view type. Default is VIEW_TYPE_WEB_CONTENTS.
+ // Icky bit of RTTI used by the extension system. This should be the user-
+ // level type of view being displayed by this WebContents - for example
+ // 'background page', or 'browser action popup', or 'tab contents'.
+ // By default, this is TYPE_INVALID; clients must set a type if necessary.
+ // TODO(aa): This should go away.
content::ViewType view_type_;
// Color chooser that was opened by this tab.
« chrome/common/chrome_view_type.h ('K') | « chrome/renderer/extensions/extension_custom_bindings.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698