Pass the referrer policy with the referrer for the save package code path

Pass the referrer policy with the referrer for the save package code path

BUG=124750
TEST=none. That code path doesn't actually use referrers, it just passes empty GURL()s around. But it might one day. And then it supports referrer policies. Hurray.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136723

[jochen (gone - plz use gerrit), 2012-05-11 21:04:59]

Randy, please review

avi: owner approval for content/
tony: owner approval for webkit/

[Avi (use Gerrit), 2012-05-11 21:17:33]

lgtm with nit

http://codereview.chromium.org/10387090/diff/1/webkit/glue/dom_operations.h
File webkit/glue/dom_operations.h (right):

http://codereview.chromium.org/10387090/diff/1/webkit/glue/dom_operations.h#n...
webkit/glue/dom_operations.h:35: // and the corresponding referrer policies.
All the other comments here are // (type) which contains (blah blah). To fit in,
this should be // vector which contains the corresponding referrer policies.

[jochen (gone - plz use gerrit), 2012-05-11 21:18:15]

updates

[tony, 2012-05-11 21:27:04]

I defer to rdsmith for correctness.  LGTM if it LG to him.

[Randy Smith (Not in Mondays), 2012-05-11 22:56:44]

I'd like Ben to be aware of this and give it a once over, just because he's our
current expert on the save package code.  I'll glance over it too, but I think
Ben's review is probably plenty.

[benjhayden, 2012-05-11 23:05:36]

http://codereview.chromium.org/10387090/diff/6002/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

http://codereview.chromium.org/10387090/diff/6002/content/renderer/render_vie...
content/renderer/render_view_impl.cc:4454:
content::Referrer(referrer_urls_list[i], referrer_policies_list[i]));
Do you want to defend against referrer_policies_list.size() <
referrer_urls_list.size()?

[Randy Smith (Not in Mondays), 2012-05-11 23:14:39]

LGTM.  I'm a little concerned about trusting that because I'm not particularly
familiar with the renderer side code, and Tony's counting on me :-}, but I tried
to go through it carefully.